-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-10] [$250] [CRITICAL] [UX Reliability] Transaction chat appears in the LHN without GBR/RBR or pinned in #focus mode #43602
Comments
Triggered auto assignment to @mallenexpensify ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Job added to Upwork: https://www.upwork.com/jobs/~01bc533ed41d18d04f |
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach ( |
Upwork job price has been updated to $250 |
Adding screenshot/data for a similar issue I'm seeing but this one is related to the receipt requirement which has been added to the policy, which wasn't effective at the time this report was originally created/submitted. Onyx Data:
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Transactions in the LHN without RBR don't disappear even if they are clicked in and out What is the root cause of that problem?Let's take a look at the condition for displaying RBR in the LHN,
It uses Meanwhile, the condition for filtering reports to display in LHN itself is in Line 106 in 75c104b
It uses What changes do you think we should make in order to solve the problem?In Line 106 in 75c104b
shouldDisplayTransactionThreadViolations needs to be used to be consistent with logic to display RBR
What alternative solutions did you explore? (Optional) |
@truph01 |
Plus in this PR we will refactor the condition for displaying violations for Sidebar |
@ZhenjaHorbach Yes I could reproduce it, just by following the steps in issue description.
@ZhenjaHorbach I'm not sure we should do this, this is a CRITICAL issue so I think it should get fixed as soon as possible. The PR you linked fix many different parts of the code so might take a while to get merged. |
I tried several times to reproduce this issue |
@ZhenjaHorbach Below is the video (with a fresh new account): The steps are like OP:
|
Thanks a lot ! |
Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@ZhenjaHorbach PR #44233 is ready |
Cool, thanks |
Cool, we fixed it appearing in the LHN. @truph01 can you please also figure out why Puneet's reports were showing the missing translations errors? It looks related to the Departments field. |
I am checking it |
@ZhenjaHorbach Can you reproduce the missing translations errors as mentioned in above: |
Unfortunately no 🙁 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-10. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@mallenexpensify |
Contributor: @truph01 paid $250 via Upwork @ZhenjaHorbach the @ZhenjaHorbach can you fill out the BZ checklist above? Thx |
Unfortunately, I didn’t find the PR that introduced the bug
NA
NA
Regression Test Proposal
Do we agree 👍 or 👎 |
Thanks @ZhenjaHorbach ! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1718138583958989
Action Performed:
preference
Expected Result:
There should be no expense report items in the LHN without GBR RBR or pinned
Actual Result:
missing translation
errorsNOTE: Included the value of the transaction, report, and violations objects
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
transactionViolations_997722480123927492 from Onyx
transactions_997722480123927492 from Onyx
transaction thread report_954645210570433 from Onyx
expense report report_3961426678972217 from Onyx
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mallenexpensifyThe text was updated successfully, but these errors were encountered: