Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When holding an expense on mobile the keyboard is blocking the bottom sheet with no way of dismissing the keyboard #46515

Closed
1 of 6 tasks
m-natarajan opened this issue Jul 30, 2024 · 20 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.14-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722340938958869

Action Performed:

  1. User A creates a workspace with a brand new account
  2. Invite user B to the workspace
  3. User B submits a report with two expenses to approver
  4. As approver, User A, holds one of the expenses and enters a reason why.

Expected Result:

On the educational screen keyboard should be dismissible and should not block the bottom.

Actual Result:

keyboard is blocking the bottom sheet with no way of dismissing the keyboard

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

IMG_0742

GKFK6469.1.MP4

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 30, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@abzokhattab
Copy link
Contributor

abzokhattab commented Jul 30, 2024

Unable to reproduce on the latest main

Screen.Recording.2024-07-30.at.6.48.26.PM.mov

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Aug 6, 2024

@strepanier03 Still overdue 6 days?! Let's take care of this!

@strepanier03
Copy link
Contributor

I can't get BrowserStack going to test this. Requested help testing here.

If the tester can't repro, I think we should tag need repro and close for now.

Copy link

melvin-bot bot commented Aug 13, 2024

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Aug 13, 2024

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

@mallenexpensify
Copy link
Contributor

@dubielzyk-expensify do you know what triggers the educational pop up? I didn't get it with my test. It's possible I've tested holding an expense before so it didn't show.

RPReplay_Final1723590186.MP4

@melvin-bot melvin-bot bot removed the Overdue label Aug 13, 2024
@mallenexpensify mallenexpensify added Needs Reproduction Reproducible steps needed Overdue retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Aug 13, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@dubielzyk-expensify
Copy link
Contributor

@dubielzyk-expensify do you know what triggers the educational pop up? I didn't get it with my test. It's possible I've tested holding an expense before so it didn't show.

It only seems to trigger on your first ever "Held" expense. So you'll need to create a test account or something

Copy link

melvin-bot bot commented Aug 19, 2024

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

@mallenexpensify
Copy link
Contributor

@dubielzyk-expensify , for testing, is the expanded version this?:

Action Performed:

  1. User A creates a workspace with a brand new account
  2. Invite user B to the workspace
  3. User B submits a report with two expenses to approver
  4. As approver, User A, holds one of the expenses and enters a reason why.

OG version

Action Performed:

  1. Submit a report with couple expenses to approver
  2. As approver hold one of the expense
  3. Enter reason

Expected Result:

On the educational screen keyboard should be dismissible and should not block the bottom.

Actual Result:

keyboard is blocking the bottom sheet with no way of dismissing the keyboard

I started a test but, after inviting a a user to a workspace, then logging in as that user, I don't see the workspace featured in the list. Reported in #expensify-bugs
https://expensify.slack.com/archives/C049HHMV9SM/p1724113581404369

@melvin-bot melvin-bot bot removed the Overdue label Aug 20, 2024
@dubielzyk-expensify
Copy link
Contributor

I believe so, yes

@mallenexpensify
Copy link
Contributor

Thx, updated OP. Waiting to hear back about bug I encountered then will revisit.

@melvin-bot melvin-bot bot added the Overdue label Aug 23, 2024
Copy link

melvin-bot bot commented Aug 26, 2024

@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

@mallenexpensify
Copy link
Contributor

ugggggh, ran into another bug while trying to test today, commented here

Will revisit again soon

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 28, 2024
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Aug 30, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@mallenexpensify
Copy link
Contributor

Since it's not reproducible, going to (continue to) drag my feet a bit.

@melvin-bot melvin-bot bot removed the Overdue label Sep 10, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mallenexpensify
Copy link
Contributor

Gonna close since it's not repro twice. Thanks @mvtglobally for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants