Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Expense shared with accountant shows incorrect rate #46897

Open
1 of 6 tasks
m-natarajan opened this issue Aug 6, 2024 · 72 comments
Open
1 of 6 tasks

[$250] Expense shared with accountant shows incorrect rate #46897

m-natarajan opened this issue Aug 6, 2024 · 72 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Waiting for copy User facing verbiage needs polishing

Comments

@m-natarajan
Copy link

m-natarajan commented Aug 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @paultsimura
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722892285723489

Action Performed:

  1. Open the chat with yourself
  2. Submit a Distance request
  3. In the Concierge prompt, click "Share it with my accountant"
  4. Select a workspace and a different rate
  5. Submit the request
  6. Navigate to the request details page

Expected Result:

  • The Rate field shows the value selected while sharing the expense.
  • There should be a proper descriptive "shared the expense" report action in the thread or no action at all

Actual Result:

  • The Rate field shows a default p2p rate ($0.89)
  • There is a "changed the expense" report action in the thread

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

354815793-ed56f179-938c-4d0c-9569-4416a6093059.mp4
Recording.415.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019b051306a76e7ed6
  • Upwork Job ID: 1821591099314477155
  • Last Price Increase: 2024-10-24
  • Automatic offers:
    • paultsimura | Contributor | 104594407
Issue OwnerCurrent Issue Owner: @Pujan92 / @mallenexpensify
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 6, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sonialiap sonialiap added the External Added to denote the issue can be worked on by a contributor label Aug 8, 2024
@melvin-bot melvin-bot bot changed the title Distance: expense shared with accountant shows incorrect rate [$250] Distance: expense shared with accountant shows incorrect rate Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~019b051306a76e7ed6

@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2024
Copy link

melvin-bot bot commented Aug 13, 2024

@Pujan92, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Aug 13, 2024
@neil-marcellini neil-marcellini changed the title [$250] Distance: expense shared with accountant shows incorrect rate [$250][P2P Distance] Expense shared with accountant shows incorrect rate Aug 13, 2024
@wildan-m
Copy link
Contributor

How can we enable the rate option for personal track expense? I think distance rate feature only available in workspace

Copy link

melvin-bot bot commented Aug 15, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 15, 2024

@Pujan92, @sonialiap Still overdue 6 days?! Let's take care of this!

@sonialiap
Copy link
Contributor

@wildan-m I believe you're correct that you can't change the rate on a personal expense, but you don't need to do that. For this issue you want to have a workspace with multiple rates. Then, once you share the expense with someone on that workspace you will have the option to select one of the workspace rates

@sonialiap
Copy link
Contributor

I'm OOO Aug 19-30, adding leave buddy

Status: Status: waiting for/ c+ reviewing proposals

@sonialiap sonialiap added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2024
@paultsimura
Copy link
Contributor

I would suggest holding this issue for #47136 - I’m planning to address a couple of Rate-related issues in it holistically. Currently we are discussing potential BE changes that will help eliminate multiple existing bugs easier.

Copy link

melvin-bot bot commented Aug 19, 2024

@Pujan92, @sonialiap, @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 20, 2024

@Pujan92 @sonialiap @mallenexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Dec 13, 2024

@paultsimura / @Pujan92 @sonialiap / @mallenexpensify @paultsimura / @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mallenexpensify
Copy link
Contributor

hmm... wonder why @paultsimura is mentioned twice above. Going to :donothing: since I've yet to see this before

SnagitHelper2024 2024-12-13 16 41 00

@paultsimura
Copy link
Contributor

We've ended up reverting the PR here.
I will need to work on a second round. We'll need a BE investigation as well for #53995

@mallenexpensify mallenexpensify changed the title [HOLD for payment 2024-12-20] [$250] Expense shared with accountant shows incorrect rate [$250] Expense shared with accountant shows incorrect rate Dec 21, 2024
@mallenexpensify mallenexpensify removed the Awaiting Payment Auto-added when associated PR is deployed to production label Dec 21, 2024
@mallenexpensify
Copy link
Contributor

I removed the Awaiting Payment label and hold for payment in the title since the PR was reverted.

@garrettmknight garrettmknight moved this from Hold for Payment to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 24, 2024
@sonialiap
Copy link
Contributor

Not overdue, the fix is being reworked

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 24, 2024
Copy link

melvin-bot bot commented Dec 30, 2024

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Eep! 4 days overdue now. Issues have feelings too...

@paultsimura
Copy link
Contributor

Working on the fix

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 30, 2024
Copy link

melvin-bot bot commented Jan 3, 2025

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

@paultsimura
Copy link
Contributor

Not overdue. Waiting for Neil's response on the PR.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 3, 2025
Copy link

melvin-bot bot commented Jan 7, 2025

@paultsimura, @Pujan92, @sonialiap, @mallenexpensify, @neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@paultsimura
Copy link
Contributor

Not overdue. The ball is on @neil-marcellini's side atm. He's OOO from what I see.

@melvin-bot melvin-bot bot removed the Overdue label Jan 7, 2025
@sonialiap
Copy link
Contributor

Neil is OOO through the end of this week. Looks like he should be back on Monday the 13th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Waiting for copy User facing verbiage needs polishing
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

10 participants