[$250] Use the video viewing data in FS to remove it and give users a clean path straight to stage 2 onboarding from stage 1

[anmurali]

Coming from this conversation, and using the benefit of this data, we are going to remove the welcome video that appears in a modal when the new sign up completes Stage 1 onboarding:

For clarity, it is the welcome video you see after the name is entered. Nothing else changes. The user simply lands where they land today after they X out of the welcome video (or click Get Started) directly after Stage 1 onboarding

Screen.Recording.2024-08-13.at.6.41.52.PM.mov

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013dde41340f7a240d
• Upwork Job ID: 1823491384277230019
• Last Price Increase: 2024-08-13
• Automatic offers:
• ahmedGaber93 | Reviewer | 103588666
• neonbhai | Contributor | 103588671

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013dde41340f7a240d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Use the video viewing data in FS to remove it and give users a clean path straight to stage 2 onboarding from stage 1

What is the root cause of that problem?

Feature Request

What changes do you think we should make in order to solve the problem?

We will remove the navigation from here:

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 92 to 94 in a14668a

	setTimeout(() => {
	Navigation.navigate(ROUTES.WELCOME_VIDEO_ROOT);
	}, variables.welcomeVideoDelay);

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

remove the welcome video that appears in a modal when the new sign up completes onboarding

What is the root cause of that problem?

Changes request

What changes do you think we should make in order to solve the problem?

Remove this navigation to open the welcome video modal after onboarding here

App/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

Lines 90 to 94 in a14668a

	// Small delay purely due to design considerations,
	// no special technical reasons behind that.
	setTimeout(() => {
	Navigation.navigate(ROUTES.WELCOME_VIDEO_ROOT);
	}, variables.welcomeVideoDelay);

We need to remove the route, the screen file, etc too since it is not used anymore

Remove all the following codes

App/src/libs/Navigation/linkingConfig/config.ts

Lines 96 to 103 in a14668a

	[NAVIGATORS.WELCOME_VIDEO_MODAL_NAVIGATOR]: {
	screens: {
	[SCREENS.WELCOME_VIDEO.ROOT]: {
	path: ROUTES.WELCOME_VIDEO_ROOT,
	exact: true,
	},
	},
	},

App/src/NAVIGATORS.ts

Line 12 in a14668a

WELCOME_VIDEO_MODAL_NAVIGATOR: 'WelcomeVideoModalNavigator',

App/src/libs/Navigation/types.ts

Line 1289 in a14668a

[NAVIGATORS.WELCOME_VIDEO_MODAL_NAVIGATOR]: NavigatorScreenParams<WelcomeVideoModalNavigatorParamList>;

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 470 to 474 in a14668a

	<RootStack.Screen
	name={NAVIGATORS.WELCOME_VIDEO_MODAL_NAVIGATOR}
	options={onboardingModalScreenOptions}
	component={WelcomeVideoModalNavigator}
	/>

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Line 178 in a14668a

const welcomeVideoModalNavigator = state.routes.find((route) => route.name === NAVIGATORS.WELCOME_VIDEO_MODAL_NAVIGATOR);

Remove only the welcomeVideoModalNavigator

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Line 223 in a14668a

if (lhpNavigator ?? onboardingModalNavigator ?? welcomeVideoModalNavigator ?? featureTrainingModalNavigator) {

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Lines 256 to 258 in a14668a

	if (welcomeVideoModalNavigator) {
	routes.push(welcomeVideoModalNavigator);
	}

App/src/SCREENS.ts

Lines 468 to 470 in a14668a

	WELCOME_VIDEO: {
	ROOT: 'Welcome_Video_Root',
	},

App/src/libs/Navigation/types.ts

Lines 1213 to 1215 in a14668a

	type WelcomeVideoModalNavigatorParamList = {
	[SCREENS.WELCOME_VIDEO.ROOT]: undefined;
	};

And remove this file

What alternative solutions did you explore? (Optional)

[ahmedGaber93]

Coming from this conversation, and using the benefit of this data, we are going to remove the welcome video that appears in a modal when the new sign up completes Stage 1 onboarding:

@anmurali I don't have access to those links, so just for confirmation, are we will stop showing it now With the possibility of re-showing it later, or will we stop showing it permanently?

I am asking for that to determine if we will remove its files completely from source code, or just remove its implementation (the lines that displaying it)

[ahmedGaber93]

@anmurali Bump ^

[anmurali]

I would rather just remove its implementation for now. Thank you for checking @ahmedGaber93

[ahmedGaber93]

The first proposal by @neonbhai LGTM!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[neonbhai]

Thank you for assigning! Raising PR soon

[melvin-bot]

@AndrewGable, @ahmedGaber93, @neonbhai Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ahmedGaber93]

Not overdue, issue is assigned and PR in progress.

[ahmedGaber93]

This is a disabling feature issue, and it is a straight forward fix, I don't think we need a regression test here.

[ahmedGaber93]

@anmurali @AndrewGable This issue is ready for payment, The PR was deployed to production for 10 days ago base on here #47961 (comment).

[ahmedGaber93]

@anmurali @AndrewGable Bump! ^

[anmurali]

Paid.