Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HybridApp] App links - Blank state once the report modal is closed #48384

Closed
1 of 6 tasks
m-natarajan opened this issue Sep 1, 2024 · 72 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Sep 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725010261607519

Action Performed:

Pre-condition: Have hybrid app switched to NewDot
Steps:
1 Clicking a deep link from email to hybrid app for a report that is not newDot compatible yet
2. This opens the report successfully
3. Close the modal

Expected Result:

The app should switch back to oldDot as we cannot see the report in NewDot

Actual Result:

Leaves the app in blank state once the modal is closed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

RPReplay_Final1724966039.MP4
RPReplay_Final1725075927.MP4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a34c5e44750fa896
  • Upwork Job ID: 1831306673608185287
  • Last Price Increase: 2024-09-04
  • Automatic offers:
    • dukenv0307 | Reviewer | 104056620
Issue OwnerCurrent Issue Owner: @mallenexpensify / @bfitzexpensify
Issue OwnerCurrent Issue Owner: @mallenexpensify
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 1, 2024
Copy link

melvin-bot bot commented Sep 1, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@miljakljajic miljakljajic added the External Added to denote the issue can be worked on by a contributor label Sep 4, 2024
@melvin-bot melvin-bot bot changed the title Hybrid app-Blank state once the report modal is closed [$250] Hybrid app-Blank state once the report modal is closed Sep 4, 2024
Copy link

melvin-bot bot commented Sep 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01a34c5e44750fa896

@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 4, 2024
Copy link

melvin-bot bot commented Sep 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

Copy link

melvin-bot bot commented Sep 9, 2024

@miljakljajic, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@miljakljajic
Copy link
Contributor

Waiting for proposals

@trjExpensify trjExpensify changed the title [$250] Hybrid app-Blank state once the report modal is closed [$250] [HybridApp] Blank state once the report modal is closed Sep 10, 2024
@trjExpensify trjExpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 10, 2024
@trjExpensify
Copy link
Contributor

Thanks for the draftPR, @staszekscp! Who's taking over in your absence?

@staszekscp
Copy link
Contributor

Depending on the amount of other issues it's going to be @war-in or @mateuuszzzzz! We'll talk internally today, and when the time comes, the lucky one will comment under the issue 😄

@trjExpensify
Copy link
Contributor

Cool, cool.

Copy link

melvin-bot bot commented Sep 11, 2024

@miljakljajic, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@miljakljajic
Copy link
Contributor

Not overdue, PR is WIP

Copy link

melvin-bot bot commented Sep 13, 2024

@miljakljajic, @dukenv0307 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Sep 15, 2024

@miljakljajic @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Sep 17, 2024

@miljakljajic, @dukenv0307 12 days overdue. Walking. Toward. The. Light...

@war-in
Copy link
Contributor

war-in commented Sep 18, 2024

Hi 👋 I started digging into this one and have a question.

Which NewDot links do we want to support on HybridApp now?
We have a couple of them defined here (for Android) but I wonder if we want to support all of them 🤔 Please let me know 🙏

cc @trjExpensify

@trjExpensify
Copy link
Contributor

I think we should support all of the deep links we do on the standalone New Expensify app for consistency.

@miljakljajic
Copy link
Contributor

@war-in I'll assign you if you're going to be working on this!

@Julesssss Julesssss reopened this Nov 19, 2024
@Julesssss
Copy link
Contributor

We had a deploy blocker here that I fixed. We probably need other HybridApp changes so I'll hold on the testing for now.

@Julesssss Julesssss removed the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 22, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Julesssss
Copy link
Contributor

Reopening as we still need to test on a production signed build.

@Julesssss Julesssss reopened this Nov 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 26, 2024
@melvin-bot melvin-bot bot changed the title [HybridApp] App links - Blank state once the report modal is closed [HOLD for payment 2024-12-03] [HybridApp] App links - Blank state once the report modal is closed Nov 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

  • @war-in does not require payment (Contractor)

Copy link

melvin-bot bot commented Nov 26, 2024

@Julesssss @mallenexpensify @war-in The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 28, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-12-03] [HybridApp] App links - Blank state once the report modal is closed [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] [HybridApp] App links - Blank state once the report modal is closed Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @war-in does not require payment (Contractor)

@Expensify Expensify deleted a comment from melvin-bot bot Nov 28, 2024
@Julesssss Julesssss changed the title [HOLD for payment 2024-12-05] [HOLD for payment 2024-12-03] [HybridApp] App links - Blank state once the report modal is closed [HybridApp] App links - Blank state once the report modal is closed Nov 28, 2024
@Julesssss
Copy link
Contributor

Okay! Good news.

@war-in the deep links are mostly working on the prod-signed build, so our theories about testing were correct. The deep links switch app and route me to the correct page. Sometime my data isn't loaded when I link to the profile page, but I do see the LHN data when pressing <.

Other than that there are some status/navigation bar UI issues that I believe are a separate issue being handled here.

@war-in
Copy link
Contributor

war-in commented Dec 2, 2024

Nice!

Sometime my data isn't loaded when I link to the profile page, but I do see the LHN data when pressing <.

Hmm, sounds interesting 🤔 Could you create an issue for this one? I can take a look at that

@Julesssss
Copy link
Contributor

I was writing up steps, but I'm struggling to reproduce now. Lets just keep an eye on deep links, they are working for app switching nicely now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Development

No branches or pull requests

9 participants