-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HybridApp] App links - Blank state once the report modal is closed #48384
Comments
Triggered auto assignment to @miljakljajic ( |
Job added to Upwork: https://www.upwork.com/jobs/~01a34c5e44750fa896 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
@miljakljajic, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too... |
Waiting for proposals |
Thanks for the draftPR, @staszekscp! Who's taking over in your absence? |
Depending on the amount of other issues it's going to be @war-in or @mateuuszzzzz! We'll talk internally today, and when the time comes, the lucky one will comment under the issue 😄 |
Cool, cool. |
@miljakljajic, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Not overdue, PR is WIP |
@miljakljajic, @dukenv0307 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
@miljakljajic @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@miljakljajic, @dukenv0307 12 days overdue. Walking. Toward. The. Light... |
Hi 👋 I started digging into this one and have a question. Which NewDot links do we want to support on HybridApp now? |
I think we should support all of the deep links we do on the standalone New Expensify app for consistency. |
@war-in I'll assign you if you're going to be working on this! |
We had a deploy blocker here that I fixed. We probably need other HybridApp changes so I'll hold on the testing for now. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Reopening as we still need to test on a production signed build. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-03. 🎊 For reference, here are some details about the assignees on this issue:
|
@Julesssss @mallenexpensify @war-in The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-05. 🎊 For reference, here are some details about the assignees on this issue:
|
Okay! Good news. @war-in the deep links are mostly working on the prod-signed build, so our theories about testing were correct. The deep links switch app and route me to the correct page. Sometime my data isn't loaded when I link to the profile page, but I do see the LHN data when pressing Other than that there are some status/navigation bar UI issues that I believe are a separate issue being handled here. |
Nice!
Hmm, sounds interesting 🤔 Could you create an issue for this one? I can take a look at that |
I was writing up steps, but I'm struggling to reproduce now. Lets just keep an eye on deep links, they are working for app switching nicely now 🙂 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.27-0
Reproducible in staging?: Y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725010261607519
Action Performed:
Pre-condition: Have hybrid app switched to NewDot
Steps:
1 Clicking a deep link from email to hybrid app for a report that is not newDot compatible yet
2. This opens the report successfully
3. Close the modal
Expected Result:
The app should switch back to oldDot as we cannot see the report in NewDot
Actual Result:
Leaves the app in blank state once the modal is closed
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
RPReplay_Final1724966039.MP4
RPReplay_Final1725075927.MP4
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mallenexpensify / @bfitzexpensifyIssue Owner
Current Issue Owner: @mallenexpensifyThe text was updated successfully, but these errors were encountered: