Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for Payment 2024-09-18] [$125] [Search v2.1] Fix Text component styles on Android #48509

Closed
luacmartins opened this issue Sep 3, 2024 · 13 comments
Closed

[HOLD for Payment 2024-09-18] [$125] [Search v2.1] Fix Text component styles on Android #48509

luacmartins opened this issue Sep 3, 2024 · 13 comments
Assignees
@luacmartins @kadiealexander @rayane-djouah
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Sep 3, 2024 •
edited by melvin-bot bot
Loading

Problem

Coming from this comment, the Text component is truncating text even though there's available space to display more text in it.

Solution

Fix the styles for the Text component

cc @Guccio163

Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831356735046116589
  • Upwork Job ID: 1831356735046116589
  • Last Price Increase: 2024-09-19
  • Automatic offers:
    • rayane-djouah | Contributor | 103815305
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 3, 2024
@luacmartins luacmartins self-assigned this Sep 3, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 3, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@luacmartins luacmartins mentioned this issue Sep 3, 2024
Closed
@luacmartins luacmartins changed the title Fix Text component styles on Android [Search v2.1] Fix Text component styles on Android Sep 3, 2024
@luacmartins luacmartins mentioned this issue Sep 3, 2024
Merged
50 tasks
@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Sep 4, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.1] Fix Text component styles on Android [$250] [Search v2.1] Fix Text component styles on Android Sep 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021831356735046116589

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@luacmartins luacmartins assigned rayane-djouah and unassigned s77rt Sep 4, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 4, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 4, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 4, 2024
luacmartins added a commit that referenced this issue Sep 9, 2024
@luacmartins
Merge pull request #48456 from software-mansion-labs/Guccio163/46030-…
523b7bf 
…shortFiltersBug

[BUG] Change MenuItem Text style from #48509, found in #46030
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 11, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 11, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rayane-djouah
Copy link
Contributor

We've addressed the above bug in a follow-up PR: #48975

@rayane-djouah
Copy link
Contributor

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-18] according to #48954 production deploy checklist, confirmed in #48954 (comment)

@luacmartins luacmartins changed the title [$250] [Search v2.1] Fix Text component styles on Android [HOLD for Payment 2024-09-18] [$250] [Search v2.1] Fix Text component styles on Android Sep 17, 2024
@luacmartins luacmartins removed the Reviewing Has a PR in review label Sep 17, 2024
@luacmartins luacmartins added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 17, 2024
@luacmartins luacmartins moved this from Polish to Done in [#whatsnext] #expense Sep 17, 2024
@kadiealexander
Copy link
Contributor

@luacmartins was this a regression that would affect payment?

@luacmartins
Copy link
Contributor Author

Yes

@kadiealexander kadiealexander changed the title [HOLD for Payment 2024-09-18] [$250] [Search v2.1] Fix Text component styles on Android [HOLD for Payment 2024-09-18] [$125] [Search v2.1] Fix Text component styles on Android Sep 19, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 19, 2024

Upwork job price has been updated to $125

@kadiealexander
Copy link
Contributor

kadiealexander commented Sep 19, 2024 •
edited
Loading

Payouts due:

Upwork job is here.

@rayane-djouah
Copy link
Contributor

@kadiealexander - Offer accepted thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@kadiealexander kadiealexander

@rayane-djouah rayane-djouah

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
[#whatsnext] #expense
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@s77rt @luacmartins @kadiealexander @rayane-djouah