-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD on #40181] [$125] mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small #48551
Comments
Triggered auto assignment to @twisterdotcom ( |
@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Very niche, downgrading to weekly and 125. |
Job added to Upwork: https://www.upwork.com/jobs/~021832331364813666635 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 ( |
Upwork job price has been updated to $125 |
Hi ! |
📣 @QasimBham! 📣
|
Contributor details Hi ! |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@QasimBham Please refer to the Contributor Guidelines and if still interested and you're able to reproduce the issue, you can submit a proposal following the proposal template -> for clarity, it is recommended to use code examples from the codebase for both root cause and solution questions from the proposal tamplate. |
It rather looks like react-native bug. In provided video when typing on web a thin underline is visible under the letter which happens when keyboard is capturing word and no website style is applied to the text yet(means text is not yet captured by web). See when translator is used and the text is captured by keyboard same issue happens even for other markdown. This might be caused by how react-native handles text-input on browser and natively. |
I think this issue is related to styling and viewport scaling rather than react native because the issue you are facing is in mweb and not in the mobile app. |
@lanitochka17 This is not reproducible in the latest stage on mWeb and there are some commits in the related feature, maybe it was fixed since you opened the issue ? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@twisterdotcom @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Still looking for proposals! Maybe we can ask people that worked / have more context on react-native-live-markdown like @BartoszGrajdek for their take on this one and whether or not this is something worth fixing. |
Hi @ikevin127, is this issue still reproducible? Everything seems to work fine on the latest main Screen.Recording.2024-09-20.at.10.00.31.mov |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@Skalakid Hi, yes I'm able to reproduce: android-android-mweb.webmIssue seems to be that on Android: mWeb inputting alphabet characters next to emoji -> doesn't size down the emoji within the composer, which does happen on Android: Native. Note Observations
|
Hmm, I still can't reproduce this on the late main and staging. Also, I've tried to do it on the physical device, but without success. On what device are you checking this? It might be a problem with text composition and how some Android devices handle it Screen.Recording.2024-09-25.at.11.58.10.mov |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Reproducible on physical devices with Samsung keyboard, here is the PR with the fix |
Okay, would any of the above proposals resolve it @ikevin127? |
@twisterdotcom We don't have any formal proposals to review here, but as I mentioned in a comment above where I reproduced the issue - it's highly likely that the issue is This was confirmed by @Skalakid in #48551 (comment) where they also mentioned that there's already a open PR that includes the fix for this issue, on the library side. All that's left to do here is to await for that What we need to figure out next is who's going to handle the E/App version bump PR, if there's already somebody assigned for that or if we need to assign somebody. |
@ikevin127 I handled the library version bump here. The PR is already merged, so this issue should be fixed now :D |
Cool, thanks for handling that! @twisterdotcom I guess the only thing left to do here is re-test the issue and if we confirm it was fixed then we can close.
Edit
|
Unfortunately the bump was reverted, so we should put this on hold again |
Issue not reproducible during KI retests. (First week) |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.29
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4919658
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Next to emoji entering single alphabet, must turn emoji into small
Actual Result:
Next to emoji entering single alphabet, doesn't turn emoji into small in mweb. But emoji turns small in Android
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6592449_1725420302812.Screenrecorder-2024-09-04-08-47-36-296_compress_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ikevin127The text was updated successfully, but these errors were encountered: