Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on #40181] [$125] mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small #48551

Open
1 of 6 tasks
lanitochka17 opened this issue Sep 4, 2024 · 29 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.29
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4919658
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch site in both mweb and Android
  2. Open a chat
  3. Open emoji picker near compose and select an emoji
  4. In mweb, after selecting emoji, enter a single letter
  5. Note emoji remains big
  6. In mweb, after selecting emoji, enter a single number
  7. Note emoji turns small
  8. In Android, after selecting emoji, enter a single number
  9. Note emoji turns small

Expected Result:

Next to emoji entering single alphabet, must turn emoji into small

Actual Result:

Next to emoji entering single alphabet, doesn't turn emoji into small in mweb. But emoji turns small in Android

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6592449_1725420302812.Screenrecorder-2024-09-04-08-47-36-296_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021832331364813666635
  • Upwork Job ID: 1832331364813666635
  • Last Price Increase: 2024-09-28
Issue OwnerCurrent Issue Owner: @ikevin127
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 4, 2024
Copy link

melvin-bot bot commented Sep 4, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label Sep 6, 2024
@twisterdotcom
Copy link
Contributor

Very niche, downgrading to weekly and 125.

@melvin-bot melvin-bot bot removed the Overdue label Sep 7, 2024
@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Sep 7, 2024
Copy link

melvin-bot bot commented Sep 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021832331364813666635

@melvin-bot melvin-bot bot changed the title mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small [$250] mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small Sep 7, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 7, 2024
Copy link

melvin-bot bot commented Sep 7, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@twisterdotcom twisterdotcom added Weekly KSv2 and removed Daily KSv2 labels Sep 7, 2024
@twisterdotcom twisterdotcom changed the title [$250] mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small [$125] mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small Sep 7, 2024
Copy link

melvin-bot bot commented Sep 7, 2024

Upwork job price has been updated to $125

@QasimBham
Copy link

Hi !
I'm Qasim from upwork. I saw the complete code and i think i can fix that. The problem you are facing maybe issue of different styling or viewport and screen scaling. I'm confident that i can fix that.

Copy link

melvin-bot bot commented Sep 7, 2024

📣 @QasimBham! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@QasimBham
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01e6c397b6b9941e91

Hi !
I'm Qasim from upwork. I saw the complete code and i think i can fix that. Ive tested it on mweb and yes the emoji turns small after typing 2 letters. The problem you are facing maybe issue of different styling or viewport and screen scaling. I'm confident that i can fix that. Let me know if you have any further queries.

Copy link

melvin-bot bot commented Sep 7, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@ikevin127
Copy link
Contributor

@QasimBham Please refer to the Contributor Guidelines and if still interested and you're able to reproduce the issue, you can submit a proposal following the proposal template -> for clarity, it is recommended to use code examples from the codebase for both root cause and solution questions from the proposal tamplate.

@ChavdaSachin
Copy link
Contributor

ChavdaSachin commented Sep 8, 2024

It rather looks like react-native bug. In provided video when typing on web a thin underline is visible under the letter which happens when keyboard is capturing word and no website style is applied to the text yet(means text is not yet captured by web).

See these screenshot

WhatsApp Image 2024-09-09 at 00 11 19

WhatsApp Image 2024-09-09 at 00 30 07

See when translator is used and the text is captured by keyboard same issue happens even for other markdown. This might be caused by how react-native handles text-input on browser and natively.

@QasimBham
Copy link

I think this issue is related to styling and viewport scaling rather than react native because the issue you are facing is in mweb and not in the mobile app.

@klajdipaja
Copy link
Contributor

@lanitochka17 This is not reproducible in the latest stage on mWeb and there are some commits in the related feature, maybe it was fixed since you opened the issue ?

Copy link

melvin-bot bot commented Sep 14, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Sep 18, 2024

@twisterdotcom @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2024
@ikevin127
Copy link
Contributor

Still looking for proposals!

Maybe we can ask people that worked / have more context on react-native-live-markdown like @BartoszGrajdek for their take on this one and whether or not this is something worth fixing.

@Skalakid
Copy link
Contributor

Hi @ikevin127, is this issue still reproducible? Everything seems to work fine on the latest main

Screen.Recording.2024-09-20.at.10.00.31.mov

Copy link

melvin-bot bot commented Sep 21, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@ikevin127
Copy link
Contributor

@Skalakid Hi, yes I'm able to reproduce:

android-android-mweb.webm

Issue seems to be that on Android: mWeb inputting alphabet characters next to emoji -> doesn't size down the emoji within the composer, which does happen on Android: Native.

Note

Observations

  1. This only happens with alphabet characters, anything else like symbols and numbers do size down the emoji.
  2. Despite this discrepanci which happens in the Composer, when the message is actually posted -> the emoji is always sized down when there's a character before or next to it.
  3. (out of scope) The composer height also looks weird on Android: mWeb compared to Android: Native (see below).
Android: mWeb Android: Native
mweb native

@Skalakid
Copy link
Contributor

Skalakid commented Sep 25, 2024

Hmm, I still can't reproduce this on the late main and staging. Also, I've tried to do it on the physical device, but without success. On what device are you checking this? It might be a problem with text composition and how some Android devices handle it

Screen.Recording.2024-09-25.at.11.58.10.mov

Copy link

melvin-bot bot commented Sep 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@Skalakid
Copy link
Contributor

Skalakid commented Sep 30, 2024

Reproducible on physical devices with Samsung keyboard, here is the PR with the fix

@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
@twisterdotcom
Copy link
Contributor

Okay, would any of the above proposals resolve it @ikevin127?

@ikevin127
Copy link
Contributor

ikevin127 commented Sep 30, 2024

@twisterdotcom We don't have any formal proposals to review here, but as I mentioned in a comment above where I reproduced the issue - it's highly likely that the issue is react-native-live-markdown (library) related.

This was confirmed by @Skalakid in #48551 (comment) where they also mentioned that there's already a open PR that includes the fix for this issue, on the library side.

All that's left to do here is to await for that react-native-live-markdown PR to be merged and then for a react-native-live-markdown version bump PR on E/App side which will fix our issue.

What we need to figure out next is who's going to handle the E/App version bump PR, if there's already somebody assigned for that or if we need to assign somebody.

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
@Skalakid
Copy link
Contributor

Skalakid commented Oct 1, 2024

@ikevin127 I handled the library version bump here. The PR is already merged, so this issue should be fixed now :D

@ikevin127
Copy link
Contributor

ikevin127 commented Oct 1, 2024

Cool, thanks for handling that!

@twisterdotcom I guess the only thing left to do here is re-test the issue and if we confirm it was fixed then we can close.

Will test it today and get back with my results.

Edit

Unfortunately the bump was reverted, so we should put this on hold again

@thienlnam
Copy link
Contributor

Unfortunately the bump was reverted, so we should put this on hold again

@twisterdotcom twisterdotcom changed the title [$125] mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small [HOLD on #40181] [$125] mWeb - Chat - Next to emoji entering single alphabet, doesn't turn emoji into small Oct 2, 2024
@twisterdotcom twisterdotcom added Monthly KSv2 and removed Weekly KSv2 labels Oct 2, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
Status: No status
Development

No branches or pull requests

9 participants