[$125] Import categories - Unable to dismiss "Import successful" modal by clicking outside the modal

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Distance rates.
3. Select all distance rates via checkbox.
4. Click on the dropdown > Delete rates.
5. Click outside the modal.
6. Note that the modal can be dismissed by clicking outside the modal.
7. Go to Categories > 3-dot menu > Import spreadsheet.
8. Upload a valid file.
9. Map Name and Enabled.
10. Click Import.
11. Click outside the "Import successful" modal to dismiss it.

Expected Result:

"Import successful" modal can be dismissed it by clicking outside the modal.

Actual Result:

"Import successful" modal cannot be dismissed it by clicking outside the modal.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592722_1725445046306.20240904_181331.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831346879000450861
• Upwork Job ID: 1831346879000450861
• Last Price Increase: 2024-09-04
• Automatic offers:
• Krishna2323 | Contributor | 103814571

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@filip-solecki @rushatgabhane this does not have to be a blocker imho as there is a clear way to get around it

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

Import categories - Unable to dismiss "Import successful" modal by clicking outside the modal

What is the root cause of that problem?

We haven't passed onCancel prop.

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 129 to 140 in a956db6

	<ConfirmModal
	isVisible={spreadsheet?.shouldFinalModalBeOpened}
	title={spreadsheet?.importFinalModal?.title ?? ''}
	prompt={spreadsheet?.importFinalModal?.prompt ?? ''}
	onConfirm={() => {
	setIsImportingCategories(false);
	closeImportPage();
	Navigation.navigate(ROUTES.WORKSPACE_CATEGORIES.getRoute(policyID));
	}}
	confirmText={translate('common.buttonConfirm')}
	shouldShowCancelButton={false}
	/>

What changes do you think we should make in order to solve the problem?


We should pass onCancel prop and should call all the functions we call in onConfirm callback.

What alternative solutions did you explore? (Optional)

Result

[mountiny]

I can help take over as I have reviewed the offending PR

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831346879000450861

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[mountiny]

Ideally, @filip-solecki fixes this, but I think we can move ahead with @Krishna2323 proposal, but given this is very simple change I will drop the price to $125

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Payment summary:

• $125 to @Krishna2323 for the fix
• no payment to Rushat here as he is going to be paid on the project basis

[Krishna2323]

@rushatgabhane, PR ready for review.

[stephanieelliott]

Hey @rushatgabhane this is blocked on you, can you review the PR when you get a chance?

[Guccio163]

PR is merged, I think we can close this one 👌

[trjExpensify]

Category import via spreadsheet is being built in #wave-control, moving this over to that project.

[stephanieelliott]

PR is merged to main but not staging yet -- will leave this open to pay out when it's deployed to prod +7

[stephanieelliott]

Hm, this PR was deployed to prod with #48954 on 9/11, but it looks like the automation didn't work. We're past the payment date, setting up payment now.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: $125 to @Krishna2323 via Upwork -- PAID
• Contributor+: N/A, s @rushatgabhane is being paid on a project basis

Upwork job is here: https://www.upwork.com/jobs/~021831346879000450861