[$125] Rules - Page scrolls up after dismissing Auto-pay reports under RHP

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.31-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Workspace settings > Rules.
3. Enable Auto-pay approved reports.
4. Click Auto-pay reports under.
5. Dismiss the RHP via back button or click outside the RHP.

Expected Result:

The page will not scroll up after dismissing Auto-pay reports under RHP.

Actual Result:

The page scrolls up after dismissing Auto-pay reports under RHP.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6597776_1725902331166.20240910_005940.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833441015435016039
• Upwork Job ID: 1833441015435016039
• Last Price Increase: 2024-09-10
• Automatic offers:
• cretadn22 | Contributor | 103987439

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[luacmartins]

I'll demote this to NAB since it's a minor issue.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Page scrolls up after dismissing Auto-pay reports under RHP

What is the root cause of that problem?

Forgot to include SCREENS.WORKSPACE.RULES in WIDE_LAYOUT_INACTIVE_SCREENS, which caused FocusTrap to activate on SCREENS.WORKSPACE.RULES and resulted in the page scrolling up

What changes do you think we should make in order to solve the problem?

Add SCREENS.WORKSPACE.RULES to WIDE_LAYOUT_INACTIVE_SCREENS

App/src/components/FocusTrap/WIDE_LAYOUT_INACTIVE_SCREENS.ts

Line 8 in 968b610

const WIDE_LAYOUT_INACTIVE_SCREENS: string[] = [

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021833441015435016039

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Upwork job price has been updated to $125

[eVoloshchak]

@cretadn22's proposal looks good to me!

🎀👀🎀 C+ reviewed!

[melvin-bot]

Current assignee @arosiclair is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[cretadn22]

@twisterdotcom This should be ready for payment

[twisterdotcom]

Payment Summary:

• @cretadn22 paid $125 via Upwork here (Contributor)
• @eVoloshchak paid $125 via NewDot Requests (C+)