Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Search v2.2] Chat search shows messages in rooms that you have viewed, but not joined #48947

Closed
1 of 6 tasks
m-natarajan opened this issue Sep 10, 2024 · 9 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Sep 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.31-20
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726001109540449

Action Performed:

  1. With account A create a workspace-visibility room (e.g. #test-room)
  2. With account B, that is also a workspace member, view the room but don't join it
  3. With account B, navigate somewhere else in the app
  4. With account A post in #test-room
  5. With account B, go to the chats/unreads page in Search

Expected Result:

No unread message displayed in LHN

Actual Result:

The unread message displayed there, even though you aren't a member of the room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Recording.537.mp4

Snip - New Expensify - Google Chrome

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021833656418639037038
  • Upwork Job ID: 1833656418639037038
  • Last Price Increase: 2024-09-10
Issue OwnerCurrent Issue Owner: @luacmartins
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@trjExpensify
Copy link
Contributor

Yep, can repro:

image

@trjExpensify trjExpensify changed the title Chat search shows messages in rooms that you have viewed, but not joined [Search v2.2] Chat search shows messages in rooms that you have viewed, but not joined Sep 10, 2024
@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Sep 10, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.2] Chat search shows messages in rooms that you have viewed, but not joined [$250] [Search v2.2] Chat search shows messages in rooms that you have viewed, but not joined Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021833656418639037038

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 10, 2024
Copy link

melvin-bot bot commented Sep 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

@trjExpensify
Copy link
Contributor

CC: @luacmartins for vis!

@luacmartins luacmartins self-assigned this Sep 11, 2024
@luacmartins
Copy link
Contributor

This is backend work.

@luacmartins luacmartins added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 11, 2024
@trjExpensify
Copy link
Contributor

Ah cool, thanks!

@luacmartins luacmartins added the Reviewing Has a PR in review label Sep 12, 2024
@luacmartins
Copy link
Contributor

PR in review

@luacmartins
Copy link
Contributor

This is done. All internal work, so we're good to close

@github-project-automation github-project-automation bot moved this from Polish to Done in [#whatsnext] #expense Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

4 participants