Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-31][Search v2.3] - Unable to rename search with emoji and X:Y format #49210

Closed
6 tasks done
IuliiaHerets opened this issue Sep 14, 2024 · 13 comments
Closed
6 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Sep 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48566
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Search.
  3. Open any saved search.
  4. Click 3-dot menu next to it > Rename.
  5. Enter an emoji and save it.
  6. Enter name with X:Y format and save it.

Expected Result:

User should be able to rename search with emoji and X:Y format.

Actual Result:

User is unable to rename search with emoji and X:Y format.
The name changes to default name after saving search name with emoji and X:Y format.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6603112_1726296648220.20240914_145014.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @lakchote
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 14, 2024
Copy link

melvin-bot bot commented Sep 14, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Sep 14, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 14, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@luacmartins
Copy link
Contributor

This is a pretty rare edge case. Gonna demote it to NAB and we can address it as a follow up.

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2024
@luacmartins luacmartins changed the title Saved search - Unable to rename search with emoji and X:Y format [Search v2.3] - Unable to rename search with emoji and X:Y format Sep 19, 2024
@lakchote
Copy link
Contributor

Wasn't able to work on this today, I've handled the other follow up issues so they can be worked on by external contributors.
I'll work on it tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 20, 2024
@luacmartins
Copy link
Contributor

PR merged, just waiting on deploy

@luacmartins luacmartins moved this from Polish to Done in [#whatsnext] #expense Sep 26, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Oct 14, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

This issue has not been updated in over 15 days. @lakchote, @luacmartins, @muttmuure eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@luacmartins luacmartins changed the title [Search v2.3] - Unable to rename search with emoji and X:Y format [HOLD for payment 2024-10-31][Search v2.3] - Unable to rename search with emoji and X:Y format Oct 31, 2024
@luacmartins luacmartins added Internal Requires API changes or must be handled by Expensify staff Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Payment Summary

Upwork Job

  • Reviewer: @mollfpr owed $250 via NewDot

BugZero Checklist (@muttmuure)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@lakchote
Copy link
Contributor

lakchote commented Nov 4, 2024

BZ checklist to be done by @muttmuure and we're done!

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@luacmartins
Copy link
Contributor

Is payment still pending here? @muttmuure

@melvin-bot melvin-bot bot added the Overdue label Nov 7, 2024
@lakchote
Copy link
Contributor

friendly bump @muttmuure ^

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@muttmuure
Copy link
Contributor

@mollfpr - $250 via NewDot for C+

@garrettmknight
Copy link
Contributor

$250 approved for @mollfpr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Done
Development

No branches or pull requests

7 participants