[HOLD for payment 2024-10-08][$250] [Search v2.1] Don't clear the workspace switcher when changing "default filters"

[JmillsExpensify]

Problem

We've created a pretty confusing pattern for a fairly common flow, which goes like this:

• You're filtered on a workspace on Inbox
• You move to the Search page. The workspace selection is retained
• You choose a different default filter on the Search page. The workspace selection is cleared.

While the theory of clearing the workspace makes sense on paper, it's just another filter, this experience ends up feeling confusing in practice, because it's possible to go from a completely different and not clear the filter. Yet, if you're on the same page, the filter is cleared.

Solution

Let's stop clearing the workspace switcher when you select different default filters on the Search page

cc @luacmartins

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848376744190303271
• Upwork Job ID: 1848376744190303271
• Last Price Increase: 2024-10-21

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[JmillsExpensify]

Carlos - should we make this external or internal?

[luacmartins]

@Kicu wanna take this one since you worked on the policy filter?

[Kicu]

Yes please assign me, I might have some extra questions later to make sure I understand this correctly. Every issue that touches navigation requires some extra care 😅

[Kicu]

@JmillsExpensify there is a small typo here (missing word) which actually makes the description confusing for me 😅

this experience ends up feeling confusing in practice, because it's possible to go from a completely different >>WHAT<< and not clear the filter. Yet, if you're on the same page, the filter is cleared.

Do you mind updating your message?

My understanding is this:

1. You are on Search page and there is a policy chosen via Workspace Switcher
2. You click on any button on the LHN (Expenses, Trips etc) OR you click on any of the status buttons (All, Drafts, Paid etc)
3. (currently) new search query will be displayed AND the policy in Workspace Switcher will be reset to All.

The new expectation is that in point 3. policy should not be reset to All.
Correct?

[luacmartins]

Your understanding is correct. (@JmillsExpensify please correct me if I'm wrong)

[Kicu]

@luacmartins @JmillsExpensify PR ready here: #49694

[luacmartins]

Nice! Thanks for the quick turnaround! I'll take a look once @rushatgabhane is done reviewing it

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @Kicu, @luacmartins, @rushatgabhane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Kicu]

Issue was solved.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848376744190303271

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[rushatgabhane]

@JmillsExpensify could you please attach payment summary 🙇

[JmillsExpensify]

Payment summary: $250 to @rushatgabhane for PR review and testing.

[JmillsExpensify]

Payment is via NewDot, so I'm going to close this one.

[melvin-bot]

@JmillsExpensify @luacmartins Be sure to fill out the Contact List!

[garrettmknight]

$250 approved for @rushatgabhane