-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-10] [Search v1.2] "this expense" in Delete modal changes to "these expenses" after deleting an expense #49980
Comments
Triggered auto assignment to @youssef-lr ( |
Triggered auto assignment to @stephanieelliott ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-control |
hey I have some free time on my hands and will take a look at this issue. It doesn't seem like a deploy blocker to me, but it also doesn't seem too difficult so shouldn't take much time. |
Edited by proposal-police: This proposal was edited at 2024-10-01 10:43:21 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Search - "this expense" in Delete modal changes to "these expenses" after deleting an expense What is the root cause of that problem?
We don't wait for the delete popover to disappear before calling clearSelectedTransactions.
The count will be 0, and "these expenses" will be displayed instead of "this expense." We only have two options in translation Lines 881 to 885 in 28bc3cd
What changes do you think we should make in order to solve the problem?Using Modal.close
What alternative solutions did you explore? (Optional) |
This is a regression from #48258 |
I'm demoting this to NAB. |
pushed a PR with a slightly different fix than proposed one |
Merged |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-10. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The delete modal "Are you sure you want to delete this expense" will remain unchanged when deleting the expense.
Actual Result:
"this expense" in the delete modal changes to "these expenses" after deleting an expense.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6620896_1727771543282.this_these.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @stephanieelliottThe text was updated successfully, but these errors were encountered: