Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-10] [Search v1.2] "this expense" in Delete modal changes to "these expenses" after deleting an expense #49980

Closed
6 tasks done
IuliiaHerets opened this issue Oct 1, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM.
  3. Submit an expense.
  4. Go to Search.
  5. Select the expense in Step 3.
  6. Click on the dropdown.
  7. Click Delete.
  8. Delete the expense.

Expected Result:

The delete modal "Are you sure you want to delete this expense" will remain unchanged when deleting the expense.

Actual Result:

"this expense" in the delete modal changes to "these expenses" after deleting an expense.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6620896_1727771543288!thi
Bug6620896_1727771543282.this_these.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @stephanieelliott
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Oct 1, 2024
Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 1, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 1, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-control

@Kicu
Copy link
Contributor

Kicu commented Oct 1, 2024

hey I have some free time on my hands and will take a look at this issue. It doesn't seem like a deploy blocker to me, but it also doesn't seem too difficult so shouldn't take much time.
CC @luacmartins

@cretadn22
Copy link
Contributor

cretadn22 commented Oct 1, 2024

Edited by proposal-police: This proposal was edited at 2024-10-01 10:43:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - "this expense" in Delete modal changes to "these expenses" after deleting an expense

What is the root cause of that problem?

clearSelectedTransactions();

We don't wait for the delete popover to disappear before calling clearSelectedTransactions.

prompt={translate('iou.deleteConfirmation', {count: selectedTransactionsKeys.length})}

The count will be 0, and "these expenses" will be displayed instead of "this expense."

We only have two options in translation

App/src/languages/en.ts

Lines 881 to 885 in 28bc3cd

deleteConfirmation: () => ({
one: 'Are you sure that you want to delete this expense?',
other: 'Are you sure that you want to delete these expenses?',
}),
settledExpensify: 'Paid',

What changes do you think we should make in order to solve the problem?

Using Modal.close

        Modal.close(() => {
            clearSelectedTransactions();
        })

What alternative solutions did you explore? (Optional)

@luacmartins luacmartins assigned luacmartins and Kicu and unassigned youssef-lr Oct 1, 2024
@luacmartins
Copy link
Contributor

This is a regression from #48258

@luacmartins
Copy link
Contributor

I'm demoting this to NAB.

@luacmartins luacmartins added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 1, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 1, 2024
@Kicu
Copy link
Contributor

Kicu commented Oct 1, 2024

pushed a PR with a slightly different fix than proposed one

@luacmartins
Copy link
Contributor

Merged

@luacmartins luacmartins changed the title Search - "this expense" in Delete modal changes to "these expenses" after deleting an expense [Search v1.2] "this expense" in Delete modal changes to "these expenses" after deleting an expense Oct 1, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 3, 2024
@melvin-bot melvin-bot bot changed the title [Search v1.2] "this expense" in Delete modal changes to "these expenses" after deleting an expense [HOLD for payment 2024-10-10] [Search v1.2] "this expense" in Delete modal changes to "these expenses" after deleting an expense Oct 3, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2024
Copy link

melvin-bot bot commented Oct 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-10. 🎊

For reference, here are some details about the assignees on this issue:

  • @Kicu does not require payment (Contractor)

Copy link

melvin-bot bot commented Oct 3, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
  • [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@Kicu] Determine if we should create a regression test for this bug.
  • [@Kicu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 9, 2024
Copy link

melvin-bot bot commented Oct 10, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants