[HOLD for payment 2024-10-10] [HOLD for payment 2024-10-09] Live MD - Composer does not scroll down after pasting content with inline image preview

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.42-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #49250
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM.
3. Paste the following content.

test test 😊

test test 😊

Expected Result:

The composer will scroll down to the end after pasting the content.

Actual Result:

The composer does not scroll down to the end after pasting the content with inline image preview.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6620908_1727772620320.d.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to Live Markdown

[mjasikowski]

Checking...

[mjasikowski]

@Skalakid are you able to fix or revert this quickly?

[hungvu193]

@mjasikowski I can create a revert if @Skalakid is AFK. There's another DB that related to recent liver markdown version too.

[joekaufmanexpensify]

What is the bug? You're able to scroll in the video attached in OP?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.42-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Add inline images preview to the Live Markdown Input on the web" #50025

If no regressions arise, payment will be issued on 2024-10-09. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mjasikowski] The PR that introduced the bug has been identified. Link to the PR: Add inline images preview to the Live Markdown Input on the web #49250
• [@mjasikowski] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add inline images preview to the Live Markdown Input on the web #49250 (comment)
• @mjasikowski] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@mjasikowski] Determine if we should create a regression test for this bug.
• [@mjasikowski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Skalakid]

I'm not sure if it's a bug. The image preview loads asynchronously, and the scrolling into view after pasting content occurs before the image is added to the input. In my opinion, this is expected behavior, such as not scrolling the last image into view. What if the image loads for 5 seconds and a user is constantly typing? Should the whole content move to the loaded image in this case? It will look like a layout jump.

Let's discuss it with the @Expensify/design team

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Add inline images preview to the Live Markdown Input on the web" #50025

If no regressions arise, payment will be issued on 2024-10-10. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mjasikowski] The PR that introduced the bug has been identified. Link to the PR:
• [@mjasikowski] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mjasikowski] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mjasikowski] Determine if we should create a regression test for this bug.
• [@mjasikowski] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: