[$250] mWeb - Submit expense- "Hmm it's not here" message gets visible when deleting vague distance Expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.41-10
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go Offline
2. Global Create > Submit expense
3. Select Distance option
4. Disable the internet connection
5. Enter a vague start location, random characters
6. Enter a vague finish location, random characters
7. Finish the submit creation flow
8. Enable the internet connection
9. Click on the close icon of error message displayed

Expected Result:

Delete the vague distance expense without problem

Actual Result:

"Hmm it's not here" message gets visible for a second before deleting the expense

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6621450_1727809746483.Mweb_Hmm_page_before_deleting_vague_location_distance_expense.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847129435512475314
• Upwork Job ID: 1847129435512475314
• Last Price Increase: 2024-10-25
• Automatic offers:
• rayane-djouah | Reviewer | 104681071
• truph01 | Contributor | 104681072

Issue Owner

Current Issue Owner: @rayane-djouah

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[truph01]

Edited by proposal-police: This proposal was edited at 2024-10-18 04:23:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Hmm it's not here" message gets visible for a second before deleting the expense

What is the root cause of that problem?

• We clear the report data and go back in:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 496 to 497 in ea48de3

	const urlToNavigateBack = IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
	Navigation.goBack(urlToNavigateBack);

• When the go-back action is not finished, and the onyx data is updated successfully, the "Hmm its not here" screen is displayed for a while.

What changes do you think we should make in order to solve the problem?

• Remove the code:

App/src/pages/home/ReportScreen.tsx

Line 272 in c3d33fc

wasReportAccessibleRef.current = false;

will fix the issue because if the report is visited before, there is no not here page is displayed anymore.

What alternative solutions did you explore? (Optional)

• We should go back successfully and then clear the report data.

• We can do it by:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 496 to 497 in ea48de3

	const urlToNavigateBack = IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
	Navigation.goBack(urlToNavigateBack);

                            const {urlToNavigateBack} = IOU.prepareToCleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
                            Navigation.goBack(urlToNavigateBack);
                            InteractionManager.runAfterInteractions(() => {
                                IOU.cleanUpMoneyRequest(transaction?.transactionID ?? linkedTransactionID, parentReportAction, true);
                            });

[alexpensify]

Adding this one to my test list and will get to it later this week.

[alexpensify]

No update yet

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

Still on my testing list

[alexpensify]

No update

[melvin-bot]

@alexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021847129435512475314

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[alexpensify]

@rayane-djouah - can you please identify if this proposal will fix this issue? Thanks!

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

[rayane-djouah]

👀

[rayane-djouah]

Sorry for the delay, I will update today

[rayane-djouah]

@truph01 Thanks for the proposal. The RCA makes sense to me.

However, simply removing wasReportAccessibleRef.current = false; only partially fixes the bug. Instead of displaying the "Hmm it's not here" message, a loading skeleton screen appears, which still isn't ideal since we expect to navigate without any issues.

Here is a video showing the loading skeleton bug:

Video

Screen.Recording.2024-10-24.at.10.31.30.PM.mov

wasReportAccessibleRef.current = false; was initially added in this PR: PR #36477 to address Issue #35751. After removing it, I noticed the original issue is no longer reproducible. Could you provide some insight into why this might be the case?

Your alternative solution seems more viable. I tried it, and it worked well. I think we can move forward with implementing it. Do you agree?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rayane-djouah]

@truph01 Please take a look at #50022 (comment) when you get a chance

[melvin-bot]

@alexpensify @rayane-djouah this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[truph01]

Your alternative solution seems more viable. I tried it, and it worked well. I think we can move forward with implementing it.

Yes, I think that solution works well without any side effects.

[rayane-djouah]

@truph01's proposal looks good to me

I prefer the alternative solution.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[flodnv]

😕 are you able to reproduce @rayane-djouah @truph01 ?

[rayane-djouah]

@flodnv The bug has been partially addressed in the latest main branch. Instead of displaying a "Hmm it's not here" message, a loading skeleton now appears, which still deviates from the expected behavior of navigating back without intermediate incorrect display states.

You can view the issue with the skeleton loading in this video:

screen-20241031-114434.mp4

Implementing the proposed solution would ensure smooth navigation without any intermediate displays, as demonstrated in this video:

screen-20241031-114731.mp4

[flodnv]

Ah, got it, thanks. The alternative solution sounds good 👍

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[truph01]

PR is ready

[alexpensify]

Update: PR is in review!

[alexpensify]

Update: same as last week

[melvin-bot]

This issue has not been updated in over 15 days. @flodnv, @alexpensify, @rayane-djouah, @truph01 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[alexpensify]

Update: PR is moving but under review