[$250] Accounting tab appears then disappears after selecting an integration during onboarding

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: N/A Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Sign up with a new Gmail account
3. Select Manage my team's expenses on onboarding modal
4. Select employee amount > Next
5. Choose any integration > Next
6. Complete the onborading
7. Go to workspace settings

Expected Result:

Accounting tab will not appear and disappear

Actual Result:

Accounting tab appears then disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6631382_1728612818949.20241011_100847.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844716640793633414
• Upwork Job ID: 1844716640793633414
• Last Price Increase: 2024-10-11

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkuoch]

I don't think this needs to be a blocker, so removing the labels, but yes let's find someone to work on it!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844716640793633414

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting tab appears then disappears after selecting an integration during onboarding

What is the root cause of that problem?

Right here when we complete the onboarding we set the areConnectionsEnabled to true:

App/src/libs/actions/Report.ts

Lines 3647 to 3677 in abdfb72

	if (userReportedIntegration) {
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${onboardingPolicyID}`,
	value: {
	areConnectionsEnabled: true,
	pendingFields: {
	areConnectionsEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	},
	});
	successData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${onboardingPolicyID}`,
	value: {
	pendingFields: {
	areConnectionsEnabled: null,
	},
	},
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${onboardingPolicyID}`,
	value: {
	areConnectionsEnabled: getPolicy(onboardingPolicyID)?.areConnectionsEnabled,
	pendingFields: {
	areConnectionsEnabled: null,
	},
	},
	});
	}

What changes do you think we should make in order to solve the problem?

We should remove this code

App/src/libs/actions/Report.ts

Lines 3647 to 3677 in abdfb72

	if (userReportedIntegration) {
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${onboardingPolicyID}`,
	value: {
	areConnectionsEnabled: true,
	pendingFields: {
	areConnectionsEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	},
	},
	});
	successData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${onboardingPolicyID}`,
	value: {
	pendingFields: {
	areConnectionsEnabled: null,
	},
	},
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.POLICY}${onboardingPolicyID}`,
	value: {
	areConnectionsEnabled: getPolicy(onboardingPolicyID)?.areConnectionsEnabled,
	pendingFields: {
	areConnectionsEnabled: null,
	},
	},
	});
	}

What alternative solutions did you explore? (Optional)

[twilight2294]

Edited by proposal-police: This proposal was edited at 2024-10-11 14:52:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting tab appears then disappears after selecting an integration during onboarding

What is the root cause of that problem?

We only set the areConnectionsEnabled value optimistically to true here, but then when we call the API, we only sent areConnectionsEnabled and not the policyID, so the BE won't update areConnectionsEnabled for that policy and when we get response from the api, the accounting is disabled.

What changes do you think we should make in order to solve the problem?

In CompleteGuidedSetupParams pass onboardingPolicyID as well, this makes sure we are referencing the correct policyID.:

App/src/libs/actions/Report.ts

Line 3716 in abdfb72

const parameters: CompleteGuidedSetupParams = {

Note: BE changes would also be needed to update the areConnectionsEnabled value of the policy.

We do the same thing in enablePolicyConnections here

What alternative solutions did you explore? (Optional)

[s77rt]

Oh we forgot to send the policy id cc @nkdengineer. Please raise a PR for this since it's a regression

@marcaaron regarding #49161 (comment), what's the param that we should use to send the policy id over?

[s77rt]

@allroundexperts I'd like to handle this being a "regression" from #49161

[nkdengineer]

@marcaaron regarding #49161 (comment), what's the param that we should use to send the policy id over?

@s77rt I will raise the PR when we confirm this. Or we can do this in the second PR of the new feature when the task translation is confirmed.

[marcaaron]

Should be policyID.

[marcaaron]

Or we can do this in the second PR of the new feature when the task translation is confirmed.

That sounds fine to me! Let's make sure to add that QA step.

[marcaaron]

@nkuoch I will take this over as it's related to something I missed when working with these guys.

[twilight2294]

Hey this had Help Wanted Label attached and I posted a solution here which will be used in the PR, I guess contributors are compensated in such case right @marcaaron ?

[marcaaron]

Hey @twilight294 I'd suggest bringing that up in Slack or shooting an email over to [email protected]. Typically, when something is a regression it's the responsibility of the person who implemented the PR. I appreciate the help and can provide this document to you review. And will also say that there are always exceptions. But I can't personally provide any guarantees right now.

[twilight2294]

Thanks for responding, I will write a mail to [email protected] to discuss more on this 😄

[s77rt]

Not overdue. Will be fixed in next PR

[twilight2294]

When is the PR for this issue coming?

[s77rt]

@nkdengineer is working on it. It should be part of a PR related to #48745

[melvin-bot]

@s77rt, @marcaaron, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[s77rt]

Being fixed in #51070

[melvin-bot]

@s77rt, @marcaaron, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

[s77rt]

This is fixed now. Can be closed