[HOLD for payment 2024-10-29] [$62.50] Android - Chat search - Unable to reach the bottom of chat list when scrolling down

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to any chat
3. Send many messages (so that the All list in Search > Chat is scrollable)
4. Go to Search > Chat
5. Scroll down the list in All tab

Expected Result:

The bottom of the chat list can be reached

Actual Result:

User is unable to reach the bottom of chat list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6631850_1728651988839.1728651753636_Screen_Recording_20241011_210108_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021844817953624508019
• Upwork Job ID: 1844817953624508019
• Last Price Increase: 2024-10-11
• Automatic offers:
• mkhutornyi | Reviewer | 104433861

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The bottom of the chat list can't be fully shown.

What is the root cause of that problem?

We have a contentContainerStyle to the search list which adds a margin top. It's to offset the list from the page header which was added in #48258.

App/src/pages/Search/SearchPageBottomTab.tsx

Line 134 in 45a3a13

contentContainerStyle={!selectionMode?.isEnabled ? [styles.searchListContentContainerStyles] : undefined}

However, because we use a margin, the height of the list is reduced by the amount of the margin-top (116).

What changes do you think we should make in order to solve the problem?

Use paddingTop instead of marginTop. It will offset the top but won't reduce the visible height on the screen.

App/src/styles/index.ts

Lines 3649 to 3651 in 2f1b6f1

	searchListContentContainerStyles: {
	marginTop: variables.searchListContentMarginTop,
	},

[joekaufmanexpensify]

Reproduced. A very minor issue, but an issue nonetheless. I think we can fix this, but should be lower budget, as is very minor change.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021844817953624508019

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[mkhutornyi]

@bernhardoj's proposal looks good to me.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[marcochavezf]

Thanks for the review @mkhutornyi, assigning @bernhardoj 🚀

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready
cc: @mkhutornyi

[joekaufmanexpensify]

PR out on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix bottom part of the search list are hidden #50876

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @mkhutornyi requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
• [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mkhutornyi] Determine if we should create a regression test for this bug.
• [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[joekaufmanexpensify]

@mkhutornyi could you complete BZ here so we can prep for payment?

[mkhutornyi]

• The PR that introduced the bug has been identified. Link to the PR: Hide mobile Search nav button + status tabs on scrollDown, but reveal on scrollUp #48258
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48258/files#r1819560752
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

Regression Test Proposal

1. Open Search page
2. Switch to Chat tab. (filter so the results are not too long)
3. Scroll to the bottom of the list
4. Verify the last item is fully visible

(tbh I think we can skip regression test since this is android-only and minor style issue)

[joekaufmanexpensify]

Agreed. Skipping regression test makes sense to me here. TY for completing checklist!

[joekaufmanexpensify]

All set to issue payment here. We need to pay:

• @bernhardoj - $62.50 for PR via NewDot.
• @mkhutornyi - $62.50 for C+ via Upwork.

[bernhardoj]

Requested in ND.

[joekaufmanexpensify]

TY!

[joekaufmanexpensify]

@mkhutornyi $62.50 sent and contract ended

[joekaufmanexpensify]

All set. Thanks everyone!

[melvin-bot]

@marcochavezf @joekaufmanexpensify Be sure to fill out the Contact List!

[JmillsExpensify]

$62.50 approved for @bernhardoj