Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Workspace -Tapping on user with "owner" tag doesn't shows "transfer owner" option #50913

Closed
2 of 7 tasks
IuliiaHerets opened this issue Oct 16, 2024 · 5 comments
Closed
2 of 7 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V. 9.0.49-0
Reproducible in staging?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

Pre-condition: As admin, invite a user to workspace and set him as admin

  1. Launch app
  2. Login as user who has been invited and set as admin
  3. Tap profile icon -- workspaces-- workspace
  4. Tap members
  5. Tap on user with owner tag

Expected Result:

Tapping on user with "owner" tag must show "transfer owner" option.

Actual Result:

Tapping on user with "owner" tag doesn't shows "transfer owner" option.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6635960_1729041438740.Screenrecorder-2024-10-16-06-40-58-188.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@shahinyan11
Copy link

shahinyan11 commented Oct 16, 2024

Edited by proposal-police: This proposal was edited at 2024-10-16 14:53:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Workspace -Tapping on user with "owner" tag doesn't shows "transfer owner" option

What is the root cause of that problem?

Here we display "transfer owner" when shouldRenderTransferOwnerButton function returns true. And here the shouldRenderTransferOwnerButton function directly returns true without any logic for the web platform , but here for native platform it checks if FUND_LIST is empty in Onyx.

What changes do you think we should make in order to solve the problem?

There is no description why shouldRenderTransferOwnerButton returns true for web apps, but for Android it checks FUND_LIST. But we can remove the check for native platforms

What alternative solutions did you explore? (Optional)

Understand in which cases the transfer owner option should be visible for native platforms and add this cases via || operator here

@FitseTLT
Copy link
Contributor

Might be expected according to #49411 (comment)

@bfitzexpensify
Copy link
Contributor

@FitseTLT is correct - app store reasons mean we can't do this, so it's not a bug. Closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants