Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-19] Hybrid Android app – Copilot – Unable to switch to own account from copilot account #51042

Open
1 of 8 tasks
IuliiaHerets opened this issue Oct 17, 2024 · 35 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.50-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5097100
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to Hybrid app
  2. Login as the account that has full copilot access
  3. Tap on Settings/header arrows
  4. Switch to copilot accounts
  5. Tap on Settings/header arrows again
  6. Switch to your own accounts

Expected Result:

User able to switch to own account from copilot account

Actual Result:

Error appears: Oops something went wrong

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6637677_1729169752290.video_2024-10-17_15-55-31.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @twisterdotcom
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 labels Oct 17, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 17, 2024

💬 A slack conversation has been started in #expensify-open-source

@IuliiaHerets IuliiaHerets added DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment and removed DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 DeployBlocker Indicates it should block deploying the API labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 17, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Sorry, was confused with blocker label

@jasperhuangg jasperhuangg added the DeployBlocker Indicates it should block deploying the API label Oct 17, 2024
@jasperhuangg
Copy link
Contributor

@IuliiaHerets next time add both labels, they're used to indicate that the bug could either be from the front-end or the back-end.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Oct 17, 2024

These logs seem suspect, I'll try to reproduce on my own account to see if I run into the same issue. Need to wait for the beta cache to refresh though.

The logs indicate that the authPartnerID stored with the restored token we're passing to the CreateLogin command isn't recognized.

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@twisterdotcom
Copy link
Contributor

How is this going @jasperhuangg?

@jasperhuangg
Copy link
Contributor

Haven't been able to prioritize this due to a higher priority #migrate project that I'm still working on, thanks for the bump.

The latest on the solution I'm going to be implementing is in this Slack thread.

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2024
@jasperhuangg
Copy link
Contributor

Was able to find some time to revisit this today. I'm asking some more questions here since I'm pretty unfamiliar with how our HybridApp code works.

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Nov 19, 2024

@dangrous I find that I keep running into hiccups in discussions because I wasn't the one who implemented delegated access in NewDot and don't have enough context, is there any chance you could take this off my hands since you worked on the design for that project?

@twisterdotcom
Copy link
Contributor

Which project do we think this fits in? Where did we handle Copilot before?

@jasperhuangg
Copy link
Contributor

Here's the doc, looks like we bunched it in with #wave-control before. So maybe #expense?

@dangrous
Copy link
Contributor

yeah i think it was #wave-control and we were handling the remaining bugs in #quality?

I can take this over but I may keep bothering you with questions (see Slack haha) because I am very bad at token stuff. But I can try!

@dangrous dangrous assigned dangrous and unassigned jasperhuangg Nov 21, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 25, 2024
@dangrous
Copy link
Contributor

PRs are in review and looking good on hybrid and regular app.

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 26, 2024
@dangrous
Copy link
Contributor

nearly there! App PR is approved by C+ so just getting the internal reviewer's approval

@dangrous
Copy link
Contributor

App is merged, waiting on deploy and then backend review, should be able to test this shortly

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 12, 2024
@melvin-bot melvin-bot bot changed the title Hybrid Android app – Copilot – Unable to switch to own account from copilot account [HOLD for payment 2024-12-19] Hybrid Android app – Copilot – Unable to switch to own account from copilot account Dec 12, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-19. 🎊

Copy link

melvin-bot bot commented Dec 12, 2024

@dangrous @twisterdotcom @dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@dangrous
Copy link
Contributor

Melvin's a little preemptive, not quite fixed but almost there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

6 participants