-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-19] Hybrid Android app – Copilot – Unable to switch to own account from copilot account #51042
Comments
Triggered auto assignment to @dylanexpensify ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @jasperhuangg ( |
💬 A slack conversation has been started in #expensify-open-source |
Triggered auto assignment to @stitesExpensify ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Sorry, was confused with blocker label |
@IuliiaHerets next time add both labels, they're used to indicate that the bug could either be from the front-end or the back-end. |
These logs seem suspect, I'll try to reproduce on my own account to see if I run into the same issue. Need to wait for the beta cache to refresh though. The logs indicate that the authPartnerID stored with the restored token we're passing to the CreateLogin command isn't recognized. |
How is this going @jasperhuangg? |
Haven't been able to prioritize this due to a higher priority #migrate project that I'm still working on, thanks for the bump. The latest on the solution I'm going to be implementing is in this Slack thread. |
Was able to find some time to revisit this today. I'm asking some more questions here since I'm pretty unfamiliar with how our HybridApp code works. |
@dangrous I find that I keep running into hiccups in discussions because I wasn't the one who implemented delegated access in NewDot and don't have enough context, is there any chance you could take this off my hands since you worked on the design for that project? |
Which project do we think this fits in? Where did we handle Copilot before? |
Here's the doc, looks like we bunched it in with #wave-control before. So maybe #expense? |
yeah i think it was #wave-control and we were handling the remaining bugs in #quality? I can take this over but I may keep bothering you with questions (see Slack haha) because I am very bad at token stuff. But I can try! |
PRs are in review and looking good on hybrid and regular app. |
nearly there! App PR is approved by C+ so just getting the internal reviewer's approval |
App is merged, waiting on deploy and then backend review, should be able to test this shortly |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-19. 🎊 |
@dangrous @twisterdotcom @dangrous The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Melvin's a little preemptive, not quite fixed but almost there |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v9.0.50-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5097100
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
User able to switch to own account from copilot account
Actual Result:
Error appears:
Oops something went wrong
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6637677_1729169752290.video_2024-10-17_15-55-31.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @twisterdotcomThe text was updated successfully, but these errors were encountered: