[#expense] [Bring copilot to NewDot] Re-add the Try New Expensify button (when applicable to show it) within HybridApp for Copilot

[dangrous]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

E/A issue for https://github.com/Expensify/Expensify/issues/414571 . We removed this functionality before copilot was migrated over, and now it is! @war-in is working on PRs already.

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[war-in]

Hi 👋 I'm working on PRs here (ND part, OD part)

[dangrous]

assigned!

[dangrous]

@war-in if they're ready, can you put the PRs into review? You can add a [HOLD] to the title so they won't be merged early

[war-in]

@war-in if they're ready, can you put the PRs into review? You can add a [HOLD] to the title so they won't be merged early

PRs are marked as ready for review :) Mentioned you in both 🫡

[dangrous]

@Ollyws you were assigned to review the App PR, let us know if you can take a look soon, thanks!

[war-in]

Hi 👋 I updated both PRs with the newest main and I'm waiting for the final review

[Ollyws]

Will review this one asap.

[Julesssss]

This can't be tested by External contributors, so I'll unassign you @Ollyws.

Also, @dangrous I can take over reviewing and testing of the PRs

[Julesssss]

Alright, next step is to wait for the App changes to hit prod then I'll bump the HybridApp submodule (like this) and test @war-in's HybridApp changes.

Back in a few days.

[dangrous]

Thanks @Julesssss !

[dangrous]

@war-in do you want to give a summary of that other bug with the tokens you were encountering here, so @Julesssss can weigh in? So for some reason disconnecting as a delegate calls CreateLogin which then fails here because it's sending chat-expensify-com as the partner name. I think we could probably just add that partner name to the conditional there to fix it, but I'm not sure if that would cause other side effects. I'm happy to keep working on that side of things, but would love your input!

[Julesssss]

So for some reason disconnecting as a delegate calls CreateLogin which then fails here because it's sending chat-expensify-com as the partner name.

Oh thanks for sharing, was that discussion on another issue or something? Adding chat-Expensify-com as a partner seems reasonable to me; maybe we should just ask in Slack to see if anyone sees a problem with it. But yeah it would be great if you can continue with that and I'll handle the HybridApp reviews and tests 👍

[war-in]

Oh thanks for sharing, was that discussion on another issue or something?

I DMed @dangrous to check if it's a known issue or not and forgot to write a summary here, sorry!

[dangrous]

Great, discussing in Slack here

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NO QA] Enable copilot in HybridApp #50800

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

• @war-in does not require payment (Contractor)

[melvin-bot]

@dangrous / @Julesssss @garrettmknight @war-in The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[war-in]

FYI, there's also the second PR (on the OD side) so let's not close the issue yet

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[dangrous]

Not overdue, working on existing PRs, and I'll hopefully be pushing up 1-2 PRs today to fix the token issue for Hybrid App

[melvin-bot]

@garrettmknight, @dangrous, @Julesssss, @war-in Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@garrettmknight, @dangrous, @Julesssss, @war-in Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Julesssss]

Multiple PRs ongoing.

[melvin-bot]

@garrettmknight, @dangrous, @Julesssss, @war-in Eep! 4 days overdue now. Issues have feelings too...

[dangrous]

Not overdue, the PRs that allow this to move forward are in review and then waiting on the one in review. The App PR is good to go with current backend, and now being tested with the changes. We'll be there soon!

[melvin-bot]

@garrettmknight, @dangrous, @Julesssss, @war-in 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[dangrous]

Working on one minor fix in the backend PR and then can move forward.

[dangrous]

nearly there!

[dangrous]

App is deployed - the backend PR is not yet merged but I think we won't need it to move forward with testing this and getting it done.