[HOLD for payment 2024-11-13] [$250] Copilot - Nothing happens when clicking Add copilot after returning from magic code page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Security.
3. Click Add copilot.
4. Select a user > Next.
5. Select an access level > Next.
6. Click Add copilot.
7. Click RHP back button.
8. Click Add copilot.

Expected Result:

App will proceed to magic code page.

Actual Result:

Nothing happens when clicking Add copilot after returning from magic code page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642186_1729610589423.20241022_232027.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848771830019077606
• Upwork Job ID: 1848771830019077606
• Last Price Increase: 2024-10-22
• Automatic offers:
• cretadn22 | Contributor | 104557922

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848771830019077606

[carlosmiceli]

A bit of an edge case, can probably be solved quickly so will ask for help from contributors.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens when clicking Add copilot after returning from magic code page.

What is the root cause of that problem?

We already setIsValidateCodeActionModalVisible(true) when pressing Add copilot. But when we close the validate code modal, we did not reset the isValidateCodeActionModalVisible so when pressing Add copilot again, setIsValidateCodeActionModalVisible(true) is triggered causing no state changes >> not toggle the modal again.

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Line 47 in 592343f

onPress={() => setIsValidateCodeActionModalVisible(true)}

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Lines 76 to 77 in 592343f

	{isValidateCodeActionModalVisible && (
	<DelegateMagicCodeModal

What changes do you think we should make in order to solve the problem?

Reset isValidateCodeActionModalVisible to false when we navigate back/close the validate code modal.

Introduce onClose prop to DelegateMagicCodeModal and pass from ConfirmDelegatePage:

<DelegateMagicCodeModal
    onClose={() => setIsValidateCodeActionModalVisible(false)}

And pass to ValidateCodeActionModal from DelegateMagicCodeModal.

[cretadn22]

Edited by proposal-police: This proposal was edited at 2024-10-22 17:13:44 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Nothing happens when clicking Add copilot after returning from magic code page

What is the root cause of that problem?

We have two isValidateCodeActionModalVisible in DelegateMagicCodeModal and ConfirmDelegatePage. When we navigate back we don't update isValidateCodeActionModalVisible in ConfirmDelegatePage to false

What changes do you think we should make in order to solve the problem?

Let's remove isValidateCodeActionModalVisible in DelegateMagicCodeModal. Remove this line

App/src/pages/settings/Security/AddDelegate/DelegateMagicCodeModal.tsx

Line 22 in 592343f

const [isValidateCodeActionModalVisible, setIsValidateCodeActionModalVisible] = useState(true);

We only should use one isValidateCodeActionModalVisible state on ConfirmDelegatePage in two places. To do that, we need to pass isValidateCodeActionModalVisible and setIsValidateCodeActionModalVisible from ConfirmDelegatePage

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Line 77 in 592343f

<DelegateMagicCodeModal

                    isValidateCodeActionModalVisible={isValidateCodeActionModalVisible}
                    setIsValidateCodeActionModalVisible={setIsValidateCodeActionModalVisible}

And use two props on DelegateMagicCodeModal

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jayeshmangwani]

I agree with you proposal @cretadn22. Right now, we have two different state that do the same thing but on different pages, so I think we should handle the hide/show logic from the parent component (ConfirmDelegatePage)

@cretadn22 , could you please check why we're rendering the DelegateMagicCodeModal modal conditionally with the isValidateCodeActionModalVisible check? Is it necessary, or can we simplify it?

App/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx

Lines 76 to 79 in f535280

	{isValidateCodeActionModalVisible && (
	<DelegateMagicCodeModal
	login={login}
	role={role}

[cretadn22]

@jayeshmangwani I believe we can safely remove the isValidateCodeActionModalVisible check since it’s already handled in the DelegateMagicCodeModal. We can also streamline it further in the PR

[jayeshmangwani]

@carlosmiceli Let's go with @cretadn22 's Proposal here. We can use the one source of truth and reference the isValidateCodeActionModalVisible state from the parent only

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @carlosmiceli is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Move visible state to parent component #51350

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @cretadn22 requires payment automatic offer (Contributor)

[melvin-bot]

@jayeshmangwani @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jayeshmangwani]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Refactor: reuse ValidateCodeActionModal #49445 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  IMO, A dedicated regression test isn't necessary here. If this issue recurs, it should be easily detectable during the usual add copilot flow.

[isabelastisser]

Payment summary:

@jayeshmangwani - $250 for C+ review. Requires payment through NewDot Manual Requests PENDING
@cretadn22 - Contributor - requires payment in Upwork. PAID. automatic offer

[garrettmknight]

$250 approved for @jayeshmangwani