[Awaiting checklist] [$250] Contact method - Keyboard not opened when navigating to enter magic code step

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52.1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #49445
Issue reported by: Applause Internal Team

Action Performed:

1. Open the app and log in
2. Navigate to the account settings > Profile > Contact method
3. Tap the New contact method button
4. Enter an email that will be used as a secondary login
5. Proceed to the magic code step

Expected Result:

The keyboard is opened automatically

Actual Result:

The keyboard is not opened automatically

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642245_1729612995396.video_2024-10-22_12-03-06.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021848790071589041805
• Upwork Job ID: 1848790071589041805
• Last Price Increase: 2024-10-22

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[cead22]

I couldn't reproduce on iOS native, but regardless, this doesn't need to be a blocker

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021848790071589041805

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-10-22 18:28:34 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Contact method - Keyboard not opened when navigating to enter magic code step

What is the root cause of that problem?

• useAutoFocusInput callback is not used.
  

  App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

  Line 184 in 21f7842

  ref={inputValidateCodeRef}

What changes do you think we should make in order to solve the problem?


• We should use useAutoFocusInput callback.
• We can use mergeRefs.

What alternative solutions did you explore? (Optional)

Result

[truph01]

I cannot reproduce in latest main

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard doesn't open when open the magic code step on Android.

What is the root cause of that problem?

It's a common issue on Android where we need a delay in focusing and showing the keyboard. We already do that here.

App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 111 to 129 in faf48fc

	useFocusEffect(
	useCallback(() => {
	if (!inputValidateCodeRef.current) {
	return;
	}
	if (focusTimeoutRef.current) {
	clearTimeout(focusTimeoutRef.current);
	}
	focusTimeoutRef.current = setTimeout(() => {
	inputValidateCodeRef.current?.focusLastSelected();
	}, CONST.ANIMATED_TRANSITION);
	return () => {
	if (!focusTimeoutRef.current) {
	return;
	}
	clearTimeout(focusTimeoutRef.current);
	};
	}, []),
	);

However, it's useless because we set autoFocus to the magic code input without shouldDelayFocus, so the input is focused immediately.

App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

Line 191 in faf48fc

autoFocus

What changes do you think we should make in order to solve the problem?

Since we already handle the focus manually (so it's focused whenever the screen is re-focused), we can set the autoFocus to false.

autoFocus={false}

[Ollyws]

@bernhardoj's solution LGTM.
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @cead22 is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[bernhardoj]

PR is ready

cc: @Ollyws

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix keyboard doesn't show when magic code page is shown #51453

If no regressions arise, payment will be issued on 2024-11-22. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@Ollyws @twisterdotcom @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[twisterdotcom]

Payment Summary:

• @Ollyws paid $250 via NewDot Manual Request
• @bernhardoj paid $250 via NewDot Manual Request

[twisterdotcom]

Waiting on the checklist now @Ollyws.

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj

[Ollyws]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/49445/files#r1857315081

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Open settings > Profile > Contact method
2. Tap the New contact method button
3. Enter any email that will be used as a secondary login
4. Press on anywhere to close the keyboard
5. Proceed to the magic code step
6. Verify the magic code input is focused and a keyboard is shown (mobile)

Do we agree 👍 or 👎

[Ollyws]

Requested in ND.

[garrettmknight]

$250 approved for @Ollyws