[HOLD for payment 2024-11-14] [$250] Track distance - Distance and Rate show “Pending” when tracking via Just track it route

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.55-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account has no expense

1. Go to staging.new.expensify.com
2. Go to Search
3. Click Create expense
4. Go to Distance
5. Enter waypoints > Next
6. Click Just track it

Expected Result:

Distance and Rate will show the correct distance and rate when tracking via Just track it route

Actual Result:

Distance and Rate show “Pending” when tracking via Just track it route

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6649481_1730217378679.20241029_235412.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851378732093417344
• Upwork Job ID: 1851378732093417344
• Last Price Increase: 2024-10-29
• Automatic offers:
• nkdengineer | Contributor | 104720899

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-10-29 18:55:18 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance and Rate show “Pending” when tracking via Just track it route

What is the root cause of that problem?

When we click on Just track it, we don't set the customUnitRateID as we do here

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 164 in 9f92c5e

IOU.setMoneyRequestParticipantsFromReport(transactionID, ReportUtils.getReport(selfDMReportID));

Then the mileageRate in the confirmation page here is undefined based on this logic

Which causes isDistanceRequestWithPendingRoute is true

App/src/components/MoneyRequestConfirmationList.tsx

Line 290 in 9f92c5e

const isDistanceRequestWithPendingRoute = isDistanceRequest && (!hasRoute || !rate) && !isMovingTransactionFromTrackExpense;

and waypoints pendingField is added as add which makes Pending... is displayed for distance and rate field

App/src/components/MoneyRequestConfirmationList.tsx

Lines 664 to 678 in 9f92c5e

	useEffect(() => {
	if (!isDistanceRequest || isMovingTransactionFromTrackExpense) {
	return;
	}
	/*
	Set pending waypoints based on the route status. We should handle this dynamically to cover cases such as:
	When the user completes the initial steps of the IOU flow offline and then goes online on the confirmation page.
	In this scenario, the route will be fetched from the server, and the waypoints will no longer be pending.
	*/
	IOU.setMoneyRequestPendingFields(transactionID, {waypoints: isDistanceRequestWithPendingRoute ? CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD : null});
	const distanceMerchant = DistanceRequestUtils.getDistanceMerchant(hasRoute, distance, unit, rate ?? 0, currency ?? CONST.CURRENCY.USD, translate, toLocaleDigit);
	IOU.setMoneyRequestMerchant(transactionID, distanceMerchant, true);
	}, [

What changes do you think we should make in order to solve the problem?

We should update the customUnitRateID when we click on Just track it button here. Optionally, we can only do it if the request is distance request.

const rateID = DistanceRequestUtils.getCustomUnitRateID(selfDMReportID, !canUseP2PDistanceRequests);
IOU.setCustomUnitRateID(transactionID, rateID);

App/src/pages/iou/request/step/IOURequestStepParticipants.tsx

Line 164 in 9f92c5e

IOU.setMoneyRequestParticipantsFromReport(transactionID, ReportUtils.getReport(selfDMReportID));

OPTIONAL: We can also update the reportID of the draft transaction to selfDMReportID

What alternative solutions did you explore? (Optional)

We can do this logic inside setMoneyRequestParticipantsFromReport function

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851378732093417344

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@nkdengineer Thanks for the proposal. Your RCA makes sense. Do you know at what stage we set the comment.customUnit.customUnitRateID when using the FAB Track Expense option?

[nkdengineer]

@s77rt When using FAB Track expense the customUnitRateID is updated here.

App/src/libs/actions/IOU.ts

Lines 352 to 354 in a4c8de6

	if (!isFromGlobalCreate) {
	const customUnitRateID = DistanceRequestUtils.getCustomUnitRateID(reportID);
	comment.customUnit = {customUnitRateID};

[s77rt]

@nkdengineer Got it! Thanks! The proposed solution looks good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkdengineer]

@robertjchen Please take a look when you have a chance.

[robertjchen]

👍 to proposal!

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix distance and rate show pending on just track it route #51939

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@s77rt @greg-schroeder The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[s77rt]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta #49007 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: n/a

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Account has no expenses

Test:

1. Go to Search > Expenses
2. Click Create expense
3. Choose Distance and select waypoints then click on Next
4. Click Just track it
5. Verify that all the fields display the correct values and none is "Pending"

Do we agree 👍 or 👎

[greg-schroeder]

Thanks @s77rt! Looks like we're set to go for 11/14

[s77rt]

@greg-schroeder I think you still need to create a GH issue for the testrail test

[greg-schroeder]

Yeah of course. I'll file it after I pay this on 11/14

[greg-schroeder]

Payment summary:

Contributor: @nkdengineer - $250 - Upwork
C+: @s77rt - $250 - NewDot manual request

[JmillsExpensify]

$250 approved for @s77rt