Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-05] [HOLD for payment 2024-11-28] Update the Switch to Expensify Classic survey to drive better feedback #51703

Closed
danielrvidal opened this issue Oct 29, 2024 · 22 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@danielrvidal
Copy link
Contributor

danielrvidal commented Oct 29, 2024

Problem: We are currently prompting people who Switch to Classic with a modal asking for a reason. But we do it inconsistently (on web but not mobile), and there are too many results to look at, and the results are kind of useless because they include known complaints from users we don’t actually think should be using New Expensify, and that we aren’t going to prioritize.

Solution:

Case 1: People that are redirected into NewDot.

  • This user group has the NVP tryNewDot.classicRedirect.dismissed set to false
  • We show them the existing survey when they click Switch to Expensify Classic in Settings.
  • We add a new page to the start of the flow to offer a call to speak to a product manager. Clicking Book a call will open this Calendly link in a new browser tab, and closes the RHP modal when clicked.
  • Make the free form response page in the survey not mandatory anymore

Copy:

**Would you like to speak to a product manager?** 

By switching to Expensify Classic, you will miss out on:
* Chatting directly on expenses and reports
* Ability to do everything on mobile
* Travel and expense at the speed of chat

We'd be excited to get on a call with you to understand why. You can book one with one of our senior product managers to discuss your needs.

[No thanks]
[Book a call]

image

  • [Internal - NW] Keep creating GHs for the research team. Engineering don't need to worry about this.

Case 2: People not redirected into NewDot

  • This user group has no tryNewDot NVP OR tryNewDot.classicRedirect.dismissed===true
  • We do not show them the survey when they click Switch to Expensify Classic in Settings.
  • Instead, we show them a new page to educate them on how to go directly to Expensify Classic next time.

Copy:

Quick tip... 
You can go straight to Expensify Classic by visiting expensify.com. Bookmark it for an easy shortcut!
[Take me to Expensify Classic]

image

  • [Internal - DV/TRJ] Track the button click on that page separately in FullStory, so we can see how many keep hitting this flow going forward and continue to try and curb it if it remains high. I've purposely labelled this button slightly differently to Case 1 to make it easy for us to do that.
Issue OwnerCurrent Issue Owner: @trjExpensify
@danielrvidal danielrvidal added Internal Requires API changes or must be handled by Expensify staff Planning Changes still in the thought process labels Oct 29, 2024
@danielrvidal danielrvidal self-assigned this Oct 29, 2024
@nikihatesgh nikihatesgh self-assigned this Oct 30, 2024
@caitlinwhite1 caitlinwhite1 self-assigned this Oct 31, 2024
@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 4, 2024
@anmurali
Copy link

anmurali commented Nov 5, 2024

This is going to be implemented on web and hybrid app, correct? cc @AndrewGable

@AndrewGable
Copy link
Contributor

Yes it should be implemented on all platforms 👍

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@danielrvidal
Copy link
Contributor Author

Asking for the next steps, let's try to make quick progress on this one!

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@trjExpensify trjExpensify self-assigned this Nov 13, 2024
@trjExpensify
Copy link
Contributor

Updated the solution OP to reflect where we landed. My next steps:

  • Get the Calendly link to include
  • Confirm if any of this actually needs backend (I don't think it does).
  • Get someone to start on it.

@trjExpensify
Copy link
Contributor

I've been chatting to Hans and confirmed we don't need any backend here. He's going to take on the implementation for us, starting today (tomorrow his time).

Working on getting the calendly link, and I'll add it to the OP.

@trjExpensify
Copy link
Contributor

Added the Calendly link to the OP, @hungvu193.

@hungvu193
Copy link
Contributor

Thanks Tom, I'll prepare a PR today!

@hungvu193
Copy link
Contributor

I created a PR here: #52526

Also waiting for confirmed translations here:
https://expensify.slack.com/archives/C01GTK53T8Q/p1731572881369449

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 14, 2024
@mountiny mountiny self-assigned this Nov 14, 2024
@hungvu193
Copy link
Contributor

Created a draft PR for the tests here:
#52754

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 21, 2024
@melvin-bot melvin-bot bot changed the title Update the Switch to Expensify Classic survey to drive better feedback [HOLD for payment 2024-11-28] Update the Switch to Expensify Classic survey to drive better feedback Nov 21, 2024
Copy link

melvin-bot bot commented Nov 21, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 21, 2024
Copy link

melvin-bot bot commented Nov 21, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 22, 2024
@shubham1206agra
Copy link
Contributor

@mountiny Please assign me here.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 27, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Payment Summary

Upwork Job

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@trjExpensify
Copy link
Contributor

👋 @shubham1206agra can we get the checklist please?

@trjExpensify
Copy link
Contributor

I've created a regression test request based off the tests I wrote for it in the PR here.

@trjExpensify
Copy link
Contributor

Payment summary here is correct. @hungvu193 you can go ahead and request, @shubham1206agra I've sent an offer which I'll pay after the checklist is added.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 28, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-28] Update the Switch to Expensify Classic survey to drive better feedback [HOLD for payment 2024-12-05] [HOLD for payment 2024-11-28] Update the Switch to Expensify Classic survey to drive better feedback Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

@shubham1206agra
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other: New Design

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on both staging and production
  • 2d. Reported on a PR
  • 2z. Other: New Design

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: NA

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

Case 1: People that are redirected into NewDot

  1. Go to expensify.com
  2. Choose the “1-9” signUpQualifier
  3. Sign-up for a new account
  4. Verify you’re redirected to new.expensify.com
  5. Click the Settings bottom tab
  6. Click Switch to Expensify Classic
  7. Verify you see the new “Would you like to speak to a product manager?” page.
  8. Click “Book a call”
  9. Verify a Calendly link opens in a new browser tab
  10. Go back to the new.expensify.com tab
  11. Verify the RHP modal has closed.
  12. Click Switch to Expensify Classic
  13. Click No thanks
  14. Choose any of the three radio button options
  15. Click Next
  16. Don’t enter any text in the free form text box
  17. Click Next
  18. Verify there’s no error on the page
  19. Click Switch to Expensify Classic
  20. Verify you’re redirected to expensify.com

Case 2: People not redirected into NewDot

  1. Go to expensify.com
  2. Choose the “10+” signUpQualifier
  3. Sign-up for a new account
  4. Verify you land in expensify.com
  5. Click the Support button in the LHN of OldDot
  6. Click Concierge
  7. Verify you’re redirected to new.expensify.com
  8. Click Settings bottom tab
  9. Click Switch to Expensify Classic
  10. Verify you see the “Quick tip” page only
  11. Click “Take me to Expensify Classic”
  12. Verify you’re redirected to expensify.com

Do we agree 👍 or 👎

@trjExpensify
Copy link
Contributor

Looks good. Feel free to accept the offer.

@trjExpensify
Copy link
Contributor

Paid, closing!

@garrettmknight
Copy link
Contributor

$250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

10 participants