-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-05] [HOLD for payment 2024-11-28] Update the Switch to Expensify Classic survey to drive better feedback #51703
Comments
This is going to be implemented on web and hybrid app, correct? cc @AndrewGable |
Yes it should be implemented on all platforms 👍 |
Asking for the next steps, let's try to make quick progress on this one! |
Updated the solution OP to reflect where we landed. My next steps:
|
I've been chatting to Hans and confirmed we don't need any backend here. He's going to take on the implementation for us, starting today (tomorrow his time). Working on getting the calendly link, and I'll add it to the OP. |
Added the Calendly link to the OP, @hungvu193. |
Thanks Tom, I'll prepare a PR today! |
I created a PR here: #52526 Also waiting for confirmed translations here: |
Created a draft PR for the tests here: |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-28. 🎊 For reference, here are some details about the assignees on this issue:
|
@mountiny Please assign me here. |
Payment Summary
BugZero Checklist (@trjExpensify)
|
👋 @shubham1206agra can we get the checklist please? |
I've created a regression test request based off the tests I wrote for it in the PR here. |
Payment summary here is correct. @hungvu193 you can go ahead and request, @shubham1206agra I've sent an offer which I'll pay after the checklist is added. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-05. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalTest:Case 1: People that are redirected into NewDot
Case 2: People not redirected into NewDot
Do we agree 👍 or 👎 |
Looks good. Feel free to accept the offer. |
Paid, closing! |
$250 approved for @hungvu193 |
Problem: We are currently prompting people who Switch to Classic with a modal asking for a reason. But we do it inconsistently (on web but not mobile), and there are too many results to look at, and the results are kind of useless because they include known complaints from users we don’t actually think should be using New Expensify, and that we aren’t going to prioritize.
Solution:
Case 1: People that are redirected into NewDot.
tryNewDot.classicRedirect.dismissed
set tofalse
Switch to Expensify Classic
in Settings.Book a call
will open this Calendly link in a new browser tab, and closes the RHP modal when clicked.Copy:
Case 2: People not redirected into NewDot
tryNewDot
NVP ORtryNewDot.classicRedirect.dismissed===true
Switch to Expensify Classic
in Settings.Copy:
Issue Owner
Current Issue Owner: @trjExpensifyThe text was updated successfully, but these errors were encountered: