Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance - Receipt briefly shows placeholder after receipt is generated #51785

Open
3 of 8 tasks
lanitochka17 opened this issue Oct 31, 2024 · 16 comments
Open
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9-0-56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit a manual expense (if there is no other expense)
  4. Go offline
  5. Submit a distance expense
  6. Go to transaction thread
  7. Click Distance
  8. Go online
  9. Wait for the receipt in the background to generate completely
  10. Click outside the RHP to dismiss it

Expected Result:

There will be no changes to the distance receipt and report header

Actual Result:

The distance receipt shows placeholder thumbnil and header changes to "0.00 for Pending..." briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6651123_1730377599506.20241031_202002.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 31, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@NikkiWines
Copy link
Contributor

NikkiWines commented Oct 31, 2024

This isn't really breaking enough functionality to be considered a deploy blocker but it should be fixed.

@NikkiWines
Copy link
Contributor

However, most likely coming from #51519 cc: @Gonals @ikevin127 @wildan-m

@ikevin127
Copy link
Contributor

Indeed, this is not a blocker and we discussed it in the PR (#51519 (comment)) and we decided to ship it like this because the fix for it was out of scope for the issue.

Therefore even though this is technically a regression of our PR, we decided not to count it as regression when it comes to compensation.

@NikkiWines NikkiWines added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 31, 2024
@NikkiWines
Copy link
Contributor

Ok, marking this as a new issue then

@NikkiWines NikkiWines removed their assignment Oct 31, 2024
@NikkiWines NikkiWines added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@wildan-m
Copy link
Contributor

wildan-m commented Nov 1, 2024

@NikkiWines The issue is likely internal and should be addressed in the backend to resolve discrepancies between transactionBackup and transaction data during online updates. Please refer to this link for an initial investigation into the missing fields. #48630 (comment).

@sakluger
Copy link
Contributor

sakluger commented Nov 1, 2024

This falls under #quality since the PR it stems from (#51519 (comment)) was also under #quality.

I'll mark as internal for now and raise a discussion in Slack around prioritization.

@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Nov 1, 2024
@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Nov 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@sakluger
Copy link
Contributor

No updates.

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

@sakluger this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2024
@sakluger
Copy link
Contributor

No updates.

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2024
@sakluger
Copy link
Contributor

sakluger commented Dec 2, 2024

No updates

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@jacobkim9881
Copy link
Contributor

This issue occurs, because the receipt data isn't added into queuedOnyxUpdates array. After clicking outside of RHP, the page is navigated from modal to distance request details and then openReport is activated to flush queuedOnyxUpdates array to update. So w/o the receipt data former data is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Development

No branches or pull requests

6 participants