-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room #51959
Comments
Triggered auto assignment to @flodnv ( |
Triggered auto assignment to @slafortune ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Thanks, CP requested. |
Verified fixed: #51973 (comment) |
I believe the only remaining task here is payment for @rojiphil's C+ review |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-13. 🎊 |
@flodnv The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@slafortune can you please process payment for @rojiphil's review #51959 (comment) and then close this issue? |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-14. 🎊 |
@flodnv @slafortune The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@flodnv are you suggesting skipping the holding period and pay this out early? |
Ah, no, not necessarily. We can wait. |
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
Oh! I do not need the payment for the work here, as we can consider it part of this PR where I was the C+ reviewer. |
@flodnv, @slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@flodnv, @slafortune Still overdue 6 days?! Let's take care of this! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to FAB > Submit expense.
Enter amount > Next.
Select a user that has no previous chat.
Submit the expense.
Go to staging.new.expensify.com
Go to FAB > Start chat.
Go to Room.
Create a new room.
Expected Result:
App will not crash.
Actual Result:
App crashes after submitting expense to user or creating a new room.
It also crashes by just opening new chat.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6654428_1730734261805.20241104_225638.mp4
0411_1.txt
Bug6654428_1730734261820.20241104_224248.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @slafortuneThe text was updated successfully, but these errors were encountered: