Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room #51959

Closed
3 of 8 tasks
IuliiaHerets opened this issue Nov 4, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.57-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com

  2. Go to FAB > Submit expense.

  3. Enter amount > Next.

  4. Select a user that has no previous chat.

  5. Submit the expense.

  6. Go to staging.new.expensify.com

  7. Go to FAB > Start chat.

  8. Go to Room.

  9. Create a new room.

Expected Result:

App will not crash.

Actual Result:

App crashes after submitting expense to user or creating a new room.
It also crashes by just opening new chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6654428_1730734261805.20241104_225638.mp4

0411_1.txt

Bug6654428_1730734261820.20241104_224248.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @slafortune
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 4, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 4, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 4, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 4, 2024

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@flodnv flodnv assigned flodnv and unassigned Julesssss Nov 4, 2024
@flodnv
Copy link
Contributor

flodnv commented Nov 4, 2024

Thanks, CP requested.

@Ollyws Ollyws removed their assignment Nov 5, 2024
@Julesssss
Copy link
Contributor

Julesssss commented Nov 5, 2024

@flodnv did the CP resolve the issue? I don't see any comments on the checklist or PR post-CP confirming the issue was resolved.

If it wasn't verified I will ask QA to retest. I asked QA to test here.

@Julesssss
Copy link
Contributor

Verified fixed: #51973 (comment)

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Nov 5, 2024
@Julesssss
Copy link
Contributor

I believe the only remaining task here is payment for @rojiphil's C+ review

@Julesssss Julesssss changed the title Room - App crashes after submitting expense to user or creating a new room [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room Nov 5, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 6, 2024
@melvin-bot melvin-bot bot changed the title [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room [HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room Nov 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-13. 🎊

Copy link

melvin-bot bot commented Nov 6, 2024

@flodnv The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@flodnv
Copy link
Contributor

flodnv commented Nov 6, 2024

@slafortune can you please process payment for @rojiphil's review #51959 (comment) and then close this issue?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 7, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room [HOLD for payment 2024-11-14] [HOLD for payment 2024-11-13] [WAIT FOR PAYMENT - 14th November] Room - App crashes after submitting expense to user or creating a new room Nov 7, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-14. 🎊

Copy link

melvin-bot bot commented Nov 7, 2024

@flodnv @slafortune The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@slafortune
Copy link
Contributor

@flodnv are you suggesting skipping the holding period and pay this out early?

@flodnv
Copy link
Contributor

flodnv commented Nov 7, 2024

Ah, no, not necessarily. We can wait.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 12, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Nov 14, 2024
@rojiphil
Copy link
Contributor

I believe the only remaining task here is payment for @rojiphil's C+ review

Oh! I do not need the payment for the work here, as we can consider it part of this PR where I was the C+ reviewer.
@slafortune We can close this out.

Copy link

melvin-bot bot commented Nov 15, 2024

@flodnv, @slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 19, 2024

@flodnv, @slafortune Still overdue 6 days?! Let's take care of this!

@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

7 participants