[HOLD for payment 2024-11-26] [$250] Reduce number of react-compiler/react-compiler and react-hooks/exhaustive-deps eslint comments

[blazejkustra]

Currently we disable react-compiler/react-compiler in 214 files (332 occurances), which means we don't strictly follow React rules.

This is a problem because of two reasons:

• All these components are not compiled
• With React concurrent mode turned on this could lead to unexpected bugs (especially once we upgrade to React v19)

Solution? Find a way to adjust the code in a way it doesn't break React rules.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854187628255719202
• Upwork Job ID: 1854187628255719202
• Last Price Increase: 2024-11-06

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854187628255719202

[melvin-bot]

Current assignee @dominictb is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

@alexpensify, @luacmartins, @blazejkustra, @dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alexpensify]

Update: Waiting for this one to go to production

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Chore] Fix components where react rules aren't followed #52040

If no regressions arise, payment will be issued on 2024-11-26. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @dominictb requires payment (Needs manual offer from BZ)

[melvin-bot]

@dominictb @alexpensify @dominictb The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dominictb]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Code improvements

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This is just code improvements that arise during development process, no specific PR introduced this issue.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  Tests in this PR are taken from the current production behavior and are already included in our TestRail test suite.

[alexpensify]

Not overdue, the payment day is tomorrow

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @blazejkustra is from an agency-contributor and not due payment
• ROLE: @dominictb paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1854187628255719202/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alexpensify]

Payouts due: 2024-11-26

• Contributor: N/A @blazejkustra - payment handled via agency
• Reviewer: $250 @dominictb - I sent a request via Upwork here: https://www.upwork.com/jobs/~021854187628255719202 - Please accept and I can complete the process. Thanks!

Upwork job is here.

[alexpensify]

I'm OOO this week, but I'm checking in on a few tasks. I passed by to check if there was an Upwork update. Since this one has not been approved yet, my next check in will be on Friday (PST) morning.

[alexpensify]

No update - waiting for @dominictb to accept. I'll check again on Monday.

[dominictb]

Please accept and I can complete the process

@alexpensify I have accepted

[alexpensify]

Thanks! All set here, @dominictb has been paid via Upwork.

#51972 (comment)