[HOLD for payment 2024-12-03] [Search v1.2] - When paying via search, changes are not seen in LHN and expense preview

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5201400&group_by=cases:section_id&group_order=asc&group_id=296775
Issue reported by: Applause Internal Team

Action Performed:

1. Open the staging.new.expensify.com website.
2. Tap on "Search" on the bottom of the screen.
3. On any expense with pending payment, tap on "Pay" on the preview.
4. Tap on "Inbox"
5. Verify that the recent payment is reflected on LHN on the preview of the correct chat.
6. Open the chat that contains the expense.
7. Verify the expense preview reflects the payment.

Expected Result:

When an expense is paid via search, changes should be automatically seen on LHN and on expense preview on chat.

Actual Result:

When an expense is paid via expense preview on search, chat preview in LHN stil displays "User owes xxxx" and button to pay expense is still displayed on expense preview on chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6661974_1731372902169.Pay.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856344566176088663
• Upwork Job ID: 1856344566176088663
• Last Price Increase: 2024-11-12

Issue Owner

Current Issue Owner: @abekkala / @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Kicu]

I have a problem reproducing the case where clicking on "Pay" automatically pays. For me clicking Pay opens RHP and I can correctly pay there which refreshes all the data.

I need some more info how to get an expense where the pay button would behave like on the video? Or perhaps is the problem that I don't have a card attached to my account, and thus I cannot pay directly?

@luacmartins could you please take a look at this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021856344566176088663

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[Gonals]

I am not able to reproduce this on staging on my Android web. @alitoshmatov, @francoisl, can you give it a shot? If we can't reproduce it, I think we can close or, at least, demote

[luacmartins]

I think the reason why QA can reproduce is because we have two different behaviors here:

1. If you've never paid an expense on that workspace before, we open the RHP
2. If you've already paid something on that workspace before, we save that last payment method to nvp_private_lastPaymentMethod and then the pay action on search uses that payment method to do a "one-click pay".

I'll take a look at all of these Search action blockers and see if we need to revert the original PR or I can put up a quick fix.

[Gonals]

I'm doing flow 2, though, and not seeing the bug

[luacmartins]

I think this issue is expected for now, @lakchote and I are working on moving the PHP updates for ApproveMoneyRequest and PayMoneyRequest to Auth. See this comment. I'll demote this to NAB.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show search action buttons v2 #52441

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment through NewDot Manual Requests

[melvin-bot]

@alitoshmatov @abekkala / @lschurr @alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[alitoshmatov]

Completing the checklist in original issue #51898 (comment)

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @alitoshmatov owed $250 via NewDot

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1856344566176088663/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[abekkala]

@Gonals or @luacmartins can you confirm if there are two payments due to @alitoshmatov
It looks like the checklist for this issue was completed via #51898
Does this require one payment of $250 or does each issue pay out $250?

[luacmartins]

@abekkala this issue was a regression from #51898, so I think we can process payment in the original issue only.

[lschurr]

Alright, so payment was handled over here: #51898

I think that means we can close this one right?