[HOLD for payment 2024-12-03] [Search v1.2] - Button loads infinitely when approving or paying expense in Search in offline mode

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• User has paid expense in Search before.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Go to Search.
5. Go offline.
6. Click Pay or Approve button.

Expected Result:

The expense is paid successfully in offline mode, or the button should be disabled if pay does not work in search in offline mode.

Actual Result:

The button loads infinitely when approving or paying expense in Search in offline mode.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6662139_1731391364441.20241112_140019.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Button loads infinitely when approving or paying expense in Search in offline mode

What is the root cause of that problem?

When approving a money request on the search page, we update the isActionLoading flag to show the loading icon. However, since the request cannot be completed offline, the offline icon continues to display indefinitely.

App/src/libs/actions/Search.ts

Lines 202 to 204 in e3632a9

	data: transactionID
	? {[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`]: {isActionLoading: isLoading}}
	: (Object.fromEntries(reportIDList.map((reportID) => [`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {isActionLoading: isLoading}])) as Partial<SearchReport>),

What changes do you think we should make in order to solve the problem?

Solution 1: We can disable the approve button on the search page

App/src/components/SelectionList/Search/ActionCell.tsx

Line 93 in e3632a9

<Button

Add new prop isDisabled, if isOffline is true and action is approve we will pass this prop is true and disable the button

Solution 2: Show a modal when user click on the approve button to inform users that this action cannot be performed while offline

                    <DecisionModal
                        title={translate('common.youAppearToBeOffline')}
                        prompt={translate('common.offlinePrompt')}
                        isSmallScreenWidth={isSmallScreenWidth}
                        onSecondOptionSubmit={() => setIsOfflineModalVisible(false)}
                        secondOptionText={translate('common.buttonConfirm')}
                        isVisible={isOfflineModalVisible}
                        onClose={() => setIsOfflineModalVisible(false)}
                    />

What alternative solutions did you explore? (Optional)

[luacmartins]

I'm the author of the PR that introduced this functionality. I'll work on a fix

[luacmartins]

PR in review

[luacmartins]

Fixed in staging.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Disable Search action button offline #52412
• [CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-20. 🎊

[melvin-bot]

@luacmartins @stephanieelliott @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Disable Search action button offline #52412
• [CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-21. 🎊

[melvin-bot]

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show search action buttons v2 #52441

If no regressions arise, payment will be issued on 2024-12-03. 🎊

[melvin-bot]

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

This is done