[HOLD for payment 2024-12-03] [Search v1.2] Invoice preview still shows "User owes x" after the invoice is paid

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Bug 1

1. Go to staging.new.expensify.com
2. [User A] Send an invoice to User B.
3. [User B] Go to invoice chat.
4. [User B] Pay the invoice from the main chat (not invoice report).

Bug 2

1. Go to staging.new.expensify.com
2. Open DM with User B.
3. Click + > Pay.
4. Enter amount and pay the user.

Expected Result:

Bug 1

• When it shows "Payment complete" animation, the preview will change to "User paid" and it will be accompanied by a green checkmark.
• After the payment is complete, the expense preview will show "User paid x" for both the sender and receiver.

Bug 2

• After the payment is complete, the expense preview will show "User paid x".

Actual Result:

Bug 1

• When it shows "Payment complete" animation, the preview still shows "User owes" instead of "User paid" and there is no green checkmark.
• After the payment is complete, the expense preview shows "User owes x" for both the sender and receiver, while the LHN preview shows "User paid x".

Bug 2

• After the payment is complete, the expense preview shows "User paid x", then reverts to "User owes x".

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6662173_1731394644954.bug_2.mp4

Uploading Bug6662173_1731394644956!bug_1.mp4…

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[grgia]

@IuliiaHerets WDYM by N/A - new feature, doesn't exist in prod - was this found via PR QA or regression testing?

[IuliiaHerets]

@grgia Sorry, added N/A - new feature, doesn't exist in prod by mistake. Not repro in prod. Issue was found by exploratory

[grgia]

This looks like a missing onyx update issue, maybe it's a web blocker

[grgia]

Caused by #51445

[melvin-bot]

Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[garrettmknight]

@grgia I'm not sure this needs to be a blocker since it's a feature we aren't promoting and no one's using at the moment, but I'll let you remove that if you agree.

[francoisl]

I can't repro on 9.0.60-2

Screen.Recording.2024-11-12.at.12.44.43.PM.mov

Screen.Recording.2024-11-12.at.12.44.24.PM.mov

[luacmartins]

Caused by #51445

@grgia can you elaborate on what from that PR caused this issue please?

[grgia]

@luacmartins I believe it was due to the change in settlement logic from ReportUtils. I didn't pinpoint RCA but tested on the revert and could not replicate

[luacmartins]

Cool, I'll assign it to me so I can work on a fix on v2 of my PR

[luacmartins]

@grgia @garrettmknight I'll unassign you from this issue since it's resolved. I'm keeping it open to track the fix in the v2 of my PR.

[luacmartins]

Lol the issue happens because sometimes the reportID is passed as a number and not a string. I'm pretty sure that might cause other issues since reportIDs can be larger than the 53bit allowed by JS so we'd truncate reportIDs and this might lead to other errors.

[luacmartins]

PR up

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

PR in review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show search action buttons v2 #52441

If no regressions arise, payment will be issued on 2024-12-03. 🎊

[melvin-bot]

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

This is done