[HOLD for payment 2024-12-03] [Search v1.2] - Pay button can be clicked many times without error when bank account is not set up

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Submit an expense.
4. Go to Search.
5. Click Pay.
6. Click on the dropdown.
7. Select Pay with Expensify (select the same option even when the button shows Pay with Expensify).
8. Close the RHP.
9. Click Pay button.

Expected Result:

There should be a message informing that the payment cannot be carried out because bank account is not set up.

Actual Result:

The pay button can be clicked several times and there is no error message at all.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6662295_1731406258412.20241112_180612.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[rlinoz]

Probably related to this PR #51445

But I am not sure we have a pattern for showing errors in Search, checking here https://expensify.slack.com/archives/C01GTK53T8Q/p1731409542501669

[rlinoz]

We are adding RBR in another PR #52333 and this is still under construction, so we don't need to block on this and can close it.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pay button can be clicked many times without error when bank account is not set up

What is the root cause of that problem?

Here we are only check for if lastPolicyPaymentMethod is not undefined before we call payMoneyRequestOnSearch.

App/src/libs/actions/Search.ts

Line 46 in cd3f30f

return lastPolicyPaymentMethod ? payMoneyRequestOnSearch(hash, [{reportID: item.reportID, amount, paymentType: lastPolicyPaymentMethod}], transactionID) : goToItem();

When user selects Pay with Expensify on step 7, lastPolicyPaymentMethod becomes 'ACH' payMoneyRequestOnSearch will be called. And the payment won't be settled since Pay with Expensify is not configured

What changes do you think we should make in order to solve the problem?

Instead we should call payMoneyRequestOnSearch if lastPolicyPaymentMethod is equal to Elsewhere or if the user has an expensify payment method configured

const [fundList = {} ] = useOnyx(ONYXKEYS.FUND_LIST);
const [bankAccountList = {}] = useOnyx(ONYXKEYS.BANK_ACCOUNT_LIST);

const hasExpensifyPaymentMethod = PaymentUtils.hasExpensifyPaymentMethod(paymentCardList, bankAccountList, false))

lastPolicyPaymentMethod === 'Elsewhere' || hasExpensifyPaymentMethod ? payMoneyRequestOnSearch(hash, [{reportID: item.reportID, amount, paymentType: lastPolicyPaymentMethod}], transactionID) : goToItem();

What alternative solutions did you explore? (Optional)

[luacmartins]

I'll reopen this issue and assign it to me so I can make sure it's fixed in my PR

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-20. 🎊

[melvin-bot]

@rlinoz / @luacmartins @greg-schroeder @rlinoz / @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

@rlinoz @greg-schroeder we fixed the issue via a revert. I'll unassign you but keep the issue open to make sure I address it in the v2 of my PR

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-21. 🎊

[melvin-bot]

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show search action buttons v2 #52441

If no regressions arise, payment will be issued on 2024-12-03. 🎊

[melvin-bot]

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[luacmartins]

This is done