Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-03] [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search #52375

Closed
5 of 8 tasks
IuliiaHerets opened this issue Nov 12, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Submit two expenses.
  4. Hold one of the expenses.
  5. Go to Search.
  6. Go to Outstanding.
  7. Click Pay next to the expense.
  8. Click on the dropdown button in RHP.
  9. Select Pay elsewhere.
  10. Close the RHP.
  11. Click Pay button next to the expense.
  12. Go back to Inbox.
  13. Go to the main workspace chat.

Expected Result:

The expense will show the correct amount in expense preview and LHN, with pay button.

Actual Result:

The expense shows 0.00 in LHN and there is no pay button on the expense preview.
Sometimes the expense preview also shows 0.00.

After refreshing the page, LHN shows correct amount and pay button is shown on the expense preview.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6662305_1731406821969.20241112_181523.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @MitchExpensify
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 12, 2024
Copy link

melvin-bot bot commented Nov 12, 2024

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 12, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link

melvin-bot bot commented Nov 12, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 12, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MarioExpensify
Copy link
Contributor

Checking

@MarioExpensify
Copy link
Contributor

I believe this may be related to this PR where the Search actions were introduced.

@MarioExpensify
Copy link
Contributor

@luacmartins this seem to be a missing update from the backend, do you think we can dismiss as a blocker for the app?

@MarioExpensify
Copy link
Contributor

Talked with @luacmartins, he'll be taking over. Thank you!

@luacmartins luacmartins changed the title Held expense - LHN preview shows 0.00 and no pay button when paying partially from Search [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 12, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Nov 12, 2024
@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Nov 13, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 13, 2024
@melvin-bot melvin-bot bot changed the title [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search [HOLD for payment 2024-11-20] [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 13, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Nov 13, 2024
@luacmartins luacmartins changed the title [HOLD for payment 2024-11-20] [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 13, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 14, 2024
@melvin-bot melvin-bot bot changed the title [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search [HOLD for payment 2024-11-21] [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-21. 🎊

Copy link

melvin-bot bot commented Nov 14, 2024

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@luacmartins luacmartins changed the title [HOLD for payment 2024-11-21] [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 14, 2024
@luacmartins luacmartins removed the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 14, 2024
@luacmartins luacmartins changed the title [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search [HOLD E/E 386310][Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 14, 2024
@luacmartins luacmartins changed the title [HOLD E/E 386310][Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 15, 2024
@luacmartins luacmartins added the Reviewing Has a PR in review label Nov 20, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 26, 2024
@melvin-bot melvin-bot bot changed the title [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search [HOLD for payment 2024-12-03] [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search Nov 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-03. 🎊

Copy link

melvin-bot bot commented Nov 26, 2024

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 3, 2024
Copy link

melvin-bot bot commented Dec 3, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@luacmartins
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants