[Search v2.5] Tax rate field is displayed after disabling Taxes

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v.9.0.60
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #52102
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account
3. Create a new workspace
4. Go to workspace settings > More features
5. Enable Taxes
6. Go to Search > Filters.
7. Verify that there is tax filter displayed if user has taxes
8. Go back to workspace settings > More features
9. Disable Taxes
10. Go to Search > Filters.

Expected Result:

There is no tax filter displayed if the user has no taxes.

Actual Result:

There is tax filter displayed when the user has no taxes.
The filter disappears when the user clears the cache (Troubleshoot > Clear cache and restart).

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6661873_1731361926760.Tax_rate_filter.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sumo-slonik

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[sumo-slonik]

Hey! I'm Kuba Nowakowski from Software Mansion, an expert agency, and I'd like to work on this issue!
I talked to @Kicu

[Kicu]

CC @luacmartins this looks pretty simple, probably need a more advanced if check around taxes.
I suggested that Jakub here can handle it ☝️

[luacmartins]

Gonna demote since it doesn't break any functionality

[luacmartins]

@sumo-slonik all yours

[RachCHopkins]

@luacmartins do I need to add the Help Wanted label to post on Upwork, or are @sumo-slonik and @Kicu handling it totally separate to Upwork?

[Kicu]

@RachCHopkins we work for an expert agency and no Upwork post is needed for us :)

[carlosmiceli]

Assigning myself too since I got assigned the contributor's PR for review.

[melvin-bot]

This issue has not been updated in over 15 days. @carlosmiceli, @mjasikowski, @luacmartins, @RachCHopkins, @sumo-slonik eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mjasikowski]

@sumo-slonik any updates here?

[Kicu]

It seems to me a PR was created and successfully merged 3 weeks ago?
#52462

Perhaps something failed in automation?

[luacmartins]

Correct, this PR was merged 3 weeks ago

[luacmartins]

There is no C+ here and the authors/reviewers are either internal or from SWM, so no Upwork payment is due. Closing