[HOLD for payment 2024-12-03] [Search v1.2] - Approve button is not disabled in Search when "Prevent self-approvals" is enabled

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workflows are enabled.
• Delayed submissions are disabled.
• Add approvals are enabled, and admin is the approver.
• Rules are enabled.
• "Prevent self-approvals" in Rules is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Note that Approve button is disabled.
5. Go to Search.
6. Click Approve button next to the expense.

Expected Result:

Approve button for the expense should be disabled when "Prevent self-approvals" in Rules enabled.

Actual Result:

Approve button for the expense is not disabled when "Prevent self-approvals" in Rules enabled.
User can click Approve button repeatedly.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6662595_1731422643260.20241112_223941.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[neonbhai]

Edited by proposal-police: This proposal was edited at 2024-11-12 15:35:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Approve button is not disabled in Search when "Prevent self-approvals" is enabled

What is the root cause of that problem?

We don't disable the button here according to isAllowedToApproveExpenseReport:

App/src/components/SelectionList/Search/ActionCell.tsx

Lines 92 to 101 in 5e52372

	return (
	<Button
	text={text}
	onPress={goToItem}
	small
	style={[styles.w100]}
	innerStyles={buttonInnerStyles}
	isLoading={isLoading}
	success
	/>

What changes do you think we should make in order to solve the problem?

We will add a check for isAllowedToApproveExpenseReport to isDisabled prop for the Button here

App/src/libs/ReportUtils.ts

Lines 7986 to 7990 in 8a1052a

	function isAllowedToApproveExpenseReport(report: OnyxEntry<Report>, approverAccountID?: number): boolean {
	const policy = getPolicy(report?.policyID);
	const isOwner = (approverAccountID ?? currentUserAccountID) === report?.ownerAccountID;
	return !(policy?.preventSelfApproval && isOwner);
	}

We can either pass a prop with the value here, here, and here or perform the check in ActionCell.tsx itself by passing the report item.

[francoisl]

@srikarparsi are you able to look into this?

[srikarparsi]

Sorry, I didn't see this earlier, looking into it now.

[srikarparsi]

Able to reproduce on staging:

Not able to reproduce on production, so is a blocker:

[srikarparsi]

Looks like this PR which adds the action buttons @luacmartins, probably an edge case that we just need to account for, looking into it

[srikarparsi]

Asked a question here about expected behavior

[srikarparsi]

Carlos is taking over :)

[luacmartins]

@stephanieelliott we fixed the issue via a revert. I'll unassign you but keep the issue open to make sure I address it in the v2 of my PR

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Show search action buttons" #52434

If no regressions arise, payment will be issued on 2024-11-21. 🎊

[melvin-bot]

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show search action buttons v2 #52441

If no regressions arise, payment will be issued on 2024-12-03. 🎊

[melvin-bot]

@luacmartins @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[luacmartins]

This is done