Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Search-Currency on Submit Button Reverts to Default breifly Before Expense Submission #52474

Closed
3 of 8 tasks
IuliiaHerets opened this issue Nov 13, 2024 · 17 comments
Closed
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.61-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Sign in with a new account or an account without expenses.
  2. Go to "Search" > click "Create Expense" > change currency > add amount.
  3. Add user > click the "Submit" button.

Expected Result:

Currency on the submit button should remain as selected after changing the currency and submitting the expense.

Actual Result:

Currency briefly reverts to the default on the submit button before the expense is submitted.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6663492_1731486481796.Screen_Recording_2024-11-13_at_12.21.21_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861166191086746017
  • Upwork Job ID: 1861166191086746017
  • Last Price Increase: 2024-12-02
Issue OwnerCurrent Issue Owner: @shubham1206agra
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@FitseTLT
Copy link
Contributor

might be dupe

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@johncschuster
Copy link
Contributor

Thanks for the heads up, @FitseTLT! I'll take a look at that one tomorrow!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 19, 2024
@johncschuster
Copy link
Contributor

@IuliiaHerets I'm confused by this bug report. When I review the video, it looks like the expense was created and the user selecting a new currency (away from ETB and to USD). Then, the submit button appropriately reflected the symbol for USD.

Am I misunderstanding what you're reporting? If so, can you please elaborate?

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2024
@IuliiaHerets
Copy link
Author

@johncschuster The issue is that when you click on the ‘Summit’ button, the previous currency is displayed for a while, not the USD
image

@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@johncschuster johncschuster added the External Added to denote the issue can be worked on by a contributor label Nov 25, 2024
@melvin-bot melvin-bot bot changed the title Search-Currency on Submit Button Reverts to Default breifly Before Expense Submission [$250] Search-Currency on Submit Button Reverts to Default breifly Before Expense Submission Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021861166191086746017

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
@johncschuster
Copy link
Contributor

@IuliiaHerets Got it. Thanks for clarifying that. Can you please clarify the OP so that's made more clear?

@shubham1206agra
Copy link
Contributor

@johncschuster This might be fixed already. Can you please recheck?

@IuliiaHerets
Copy link
Author

@johncschuster Tester use Mac 13.6

@IuliiaHerets
Copy link
Author

@shubham1206agra Tester cannot reproduce the issue anymore, build - v9.0.67-1

Screen.Recording.2024-11-26.at.1.05.31.PM.mp4

Copy link

melvin-bot bot commented Nov 27, 2024

@johncschuster @shubham1206agra this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Nov 29, 2024

@johncschuster, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2024
@shubham1206agra
Copy link
Contributor

@johncschuster Please close this issue

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

@johncschuster, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants