[HOLD for payment 2024-11-29] [$250] [Workspace feeds - Direct] Search page Card filter should show card name

[JmillsExpensify]

At the moment if you try to search for direct workspace cards, we show the card feed name, like so.

Instead, we should be showing the card name in the Card filter list for search.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857041070045717217
• Upwork Job ID: 1857041070045717217
• Last Price Increase: 2024-11-14
• Automatic offers:
• allgandalf | Contributor | 104897589

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[narefyev91]

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857041070045717217

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[JmillsExpensify]

No proposals are needed on this issue, though adding the External label so we can have C+ help test/review the PR.

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Internal QA]: Show card name instead of Bank for Company cards search #52625

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @allgandalf requires payment automatic offer (Contributor)

[melvin-bot]

@allgandalf @JmillsExpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

@allgandalf can you please complete a checklist and suggest a test?

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Result of Newly introduced Company Cards feature, couldn't have been caused by any changes

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A

• Add card advanced filter for Search #46666 This PR implemented the search page filter, but it was implemented in August (At that time we didn't have company cards feature on ND), so no offending PR as such here.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• User should have Company Card and Expensify cards assigned.

Test:

1. Open App > Go to Search > Click on Filter > Card

• Verify that Expensify card is shown as "Expensify Card".
• Verify that any other card (Company Cards) is shown with card name.

Do we agree 👍 or 👎

[allgandalf]

@allgandalf can you please complete a checklist and suggest a test?

Done 🙇

[allgandalf]

Let's close this one

[melvin-bot]

@JmillsExpensify, @narefyev91, @mountiny, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

[JmillsExpensify]

Upwork contract paid out and regression test created. We should be good here.