[$250] mWeb - Expensify Classic - Survey page is not shown while switching to expensify classic

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.65-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #52352
Issue reported by:

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login expensifail account
3. Tap settings - switch to expensify classic
4. Tap take me to expensify classic

Expected Result:

Survey page must be shown while switching to expensify classic.

Actual Result:

Tapping take me to expensify expensify classic user briefly taken to settings page before navigating to expensify classic. Then survey page is not shown while switching to expensify classic.

Note : Before you go page is displayed only for new unvalidated gmail account and it is missing on all other accounts.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6671447_1732160573273.Screenrecorder-2024-11-21-09-05-15-164.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859991189955688630
• Upwork Job ID: 1859991189955688630
• Last Price Increase: 2024-11-22

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

I think after #52526. This is the expected behavior. Survey page should only show for accounts that were redirected from OD to ND before.

But I see one problem here is this:

Tapping take me to Expensify classic user briefly taken to settings page before navigating to Expensify classic.

What is the root cause of that problem?

It's due to the order of executions here:

App/src/pages/settings/ExitSurvey/ExitSurveyConfirmPage.tsx

Lines 89 to 93 in 1fb2989

	onPress={() => {
	ExitSurvey.switchToOldDot();
	Navigation.dismissModal();
	Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX);
	}}

dismissModal is called before openOldDotLink.

What changes do you think we should make in order to solve the problem?

We should move openOldDotLink before dismissModal.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859991189955688630

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

@mollfpr, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mollfpr]

This is the expected behavior. Survey page should only show for accounts that were redirected from OD to ND before.

@bfitzexpensify As it's noted in the above proposal it's expected for old accounts in ND and only showing the survey page if it's signing up from OD and redirected to the ND.

Tapping take me to Expensify classic user briefly taken to settings page before navigating to Expensify classic

I'm not sure if it's worth fixing this issue, but otherwise, we can close this.