[Search v1.2] - No approve button on the transaction in search page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #52441

Action Performed:

Pre conditions: Make sure you have a report that can be approved, i.e. create a workspace, invite a member, turn on approvals and reimbursement (workflows), as the member submit a few expenses

1. As the admin open the expenses submitted and observe the approve button appears
2. Navigate to search page

Expected Result:

Approve button appears next to the expense/report

Actual Result:

No approve buttons are appearing next to the expense/report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6674002_1732356682180.bandicam_2024-11-23_13-05-40-412.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @luacmartins

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

not able to reproduce:

[cretadn22]

@luacmartins

This is a BE bug. The BE returns a incorrect value for the isFromOneTransactionReport field

App/src/libs/SearchUIUtils.ts

Lines 269 to 271 in 3ebe852

	if (!ReportUtils.isMoneyRequestReport(report) || (isTransaction && !data[key].isFromOneTransactionReport)) {
	return CONST.SEARCH.ACTION_TYPES.VIEW;
	}

As a result, this condition is met, and the View action is displayed.

[luacmartins]

Thanks! I'll take a look at it

[luacmartins]

Hm this is expected. If the report has multiple expenses, we only show the Approve and Pay button on the "report" views, e.g. Outstanding and not on the All page

[luacmartins]

Closing