[$250] Login - Onboarding flow is dismissed before selecting accounting software.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Other

Action Performed:

1. Create a new user
2. "What do you want to do today?" modal appears > Select the option "Manage my team's expenses"
3. Choose number of employees > click continue

Expected Result:

accounting software modal is displayed and able to choose accounting software

Actual Result:

Onboarding flow is dismissed before selecting accounting software.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6691730_1733972275884.Screen_Recording_2024-12-12_at_5.01.32_at_night.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867244068382506844
• Upwork Job ID: 1867244068382506844
• Last Price Increase: 2024-12-12

Issue Owner

Current Issue Owner: @francoisl

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[c3024]

I can repro this on production too.

Screen.Recording.2024-12-12.at.2.51.40.PM.mov

Does not seem to be related to #53661.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding flow is dismissed before selecting accounting software.

What is the root cause of that problem?

When we create a new workspace at the employee step with engagementChoice is newDotManageTeam, the backend returns hasCompletedGuidedSetupFlow is true which causes the onboarding flow is dismissed

App/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

Lines 67 to 69 in bf38806

	const {adminsChatReportID, policyID} = Policy.createWorkspace(undefined, true, '', Policy.generatePolicyID(), CONST.ONBOARDING_CHOICES.MANAGE_TEAM);
	Welcome.setOnboardingAdminsChatReportID(adminsChatReportID);
	Welcome.setOnboardingPolicyID(policyID);

What changes do you think we should make in order to solve the problem?

1. If the backend is correct, we can remove the engagementChoice when we create a new workspace here and here

2. If not we need to fix this bug in backend

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867244068382506844

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[francoisl]

This is a backend issue sorry, we're working on it now.

[melvin-bot]

@francoisl, @lschurr, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allgandalf]

not overdue melv!!!

[francoisl]

This is fixed.