-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Multiple concurrent deploys are slow #9726
Comments
No update. |
Not a priority |
Also would like to bundle this together with a suite of deploy improvements |
No update |
No update |
Dropping, see #12021 (comment) |
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Problem
When a PR is cherry-picked, we wait for staging deploys to finish before commenting in the deploy checklist to alert Applause of the newly-CP'd PR.
However, if we then merge / CP another PR, we run into softprops/turnstyle here. Then the second CP sits around and waits for the pending staging deploy to finish unnecessarily before creating a new version, CPing it to staging, and updating the checklist.
Why this is important
This causes unnecessary delays in the deploy process, particularly in scenarios where we want to complete multiple CP's in a row, which are typically more urgent scenarios. It will be even more important once we have the ability to CP PR's to production, because then production CP's will be delayed waiting for unrelated staging CP's, potentially adding hours to the time it takes for us to get an urgent fix out to users.
Solution
(ideally) Figure out a way to make it so we don't have to wait for staging deploys to finish. Maybe using a post-action hook?
Otherwise, cleverly separate jobs to make all the prep work (i.e: creating a new version, CPing it to staging, etc...) not have to wait.
The text was updated successfully, but these errors were encountered: