Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] Multiple concurrent deploys are slow #9726

Closed
roryabraham opened this issue Jul 6, 2022 · 9 comments
Closed

[HOLD] Multiple concurrent deploys are slow #9726

roryabraham opened this issue Jul 6, 2022 · 9 comments
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 NewFeature Something to build that is a new item. Not a priority

Comments

@roryabraham
Copy link
Contributor

Problem

When a PR is cherry-picked, we wait for staging deploys to finish before commenting in the deploy checklist to alert Applause of the newly-CP'd PR.

However, if we then merge / CP another PR, we run into softprops/turnstyle here. Then the second CP sits around and waits for the pending staging deploy to finish unnecessarily before creating a new version, CPing it to staging, and updating the checklist.

Why this is important

This causes unnecessary delays in the deploy process, particularly in scenarios where we want to complete multiple CP's in a row, which are typically more urgent scenarios. It will be even more important once we have the ability to CP PR's to production, because then production CP's will be delayed waiting for unrelated staging CP's, potentially adding hours to the time it takes for us to get an urgent fix out to users.

Solution

(ideally) Figure out a way to make it so we don't have to wait for staging deploys to finish. Maybe using a post-action hook?

Otherwise, cleverly separate jobs to make all the prep work (i.e: creating a new version, CPing it to staging, etc...) not have to wait.

@roryabraham roryabraham added Engineering Monthly KSv2 Improvement Item broken or needs improvement. labels Jul 6, 2022
@roryabraham roryabraham self-assigned this Jul 6, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2022
@roryabraham
Copy link
Contributor Author

No update.

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2022
@roryabraham
Copy link
Contributor Author

Not a priority

@melvin-bot melvin-bot bot removed the Overdue label Sep 29, 2022
@roryabraham
Copy link
Contributor Author

Also would like to bundle this together with a suite of deploy improvements

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2022
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2022
@puneetlath puneetlath added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 2, 2022
@roryabraham roryabraham changed the title Multiple concurrent deploys are slow [HOLD] Multiple concurrent deploys are slow Nov 28, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2022
@roryabraham
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@roryabraham roryabraham removed their assignment Dec 14, 2022
@roryabraham
Copy link
Contributor Author

Dropping, see #12021 (comment)

@melvin-bot melvin-bot bot closed this as completed Feb 27, 2023
@MelvinBot
Copy link

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed May 12, 2023
@roryabraham roryabraham reopened this Jul 10, 2023
@melvin-bot melvin-bot bot closed this as completed Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2 NewFeature Something to build that is a new item. Not a priority
Projects
None yet
Development

No branches or pull requests

3 participants