Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript #35307
[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript #35307
Changes from all commits
dcd834b
7d88436
2f7f0be
75fb85f
5d83e8e
5f26b89
71889c6
9e87935
ff249fd
7cffd1c
07aeee9
d7fa1f4
9165006
3b37ccc
7d667af
d8c3281
20c98fd
9a85683
e09dcae
c627a1a
296c724
87dc6e3
f0c8f25
60f0c39
9e89e34
6d9b146
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
route.params?.country
? This is inconsistent with https://github.com/Expensify/App/pull/35307/files#diff-02dc5171dfb0335e880ff4994705c5607f8f7a82de55bd1d4fa241c499d9232dR47There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think params are always there
![image](https://private-user-images.githubusercontent.com/25230417/305124801-99565096-8278-41e0-87ee-97ccfbc2b9e4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ0NDU4NTIsIm5iZiI6MTczNDQ0NTU1MiwicGF0aCI6Ii8yNTIzMDQxNy8zMDUxMjQ4MDEtOTk1NjUwOTYtODI3OC00MWUwLTg3ZWUtOTdjY2ZiYzJiOWU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE3VDE0MjU1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThkMDVlNjI2NjdhNDZjYWRiOGQxNzMzNzY2ZjJiOTE1ZGE5NzI3YWM0OTk5MjQ1NTE2NGM3MTIzOWRiNDQ5YTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OLjWxNQhMOuuySiQ8iM0G8wmQAYRx2RMQDkV0OrPfdQ)
So this should be fine to left it as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
route.params
always exists?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here ^