feat: Add Corpay bank info step and update file upload logic #52054

pasyukevich · 2024-11-05T15:54:26Z

Explanation of Change

Fixed Issues

$ #50898
PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

QA Steps

Change workspace currency to EUR, GBP, CAD or AUD
Enable workflows for the workspace
Open workflows
Try to connect a bank account
Go to the second step - a new component should be displayed
For the first substep validations and field lists will be received from the BE
For the AUD currency we should have 3 substeps (on the second upload file step, for other currencies should be skipped)
Verify Upload picker validations (10 files limit, 5MB total, PDF/PNG/JPEG only)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-converted.webm

Android: mWeb Chrome

[android-web-converted.webm](https://github.com/user-attachments/assets/3dae1479-b1a9-4404-ad01-b37706f264a1)

iOS: Native

ios-native-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

desktop-web-converted.mov

MacOS: Desktop

desktop-native-converted.mov

… text

melvin-bot · 2024-11-07T13:26:46Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-11-08T18:36:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-13.at.1.30.07.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-13.at.2.22.41.AM.mov

iOS: Native

Screen.Recording.2024-11-09.at.5.44.58.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-09.at.5.29.20.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-09.at.5.19.12.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-14.at.4.07.30.AM-1.mov

ishpaul777 · 2024-11-08T18:36:51Z

we have conflicts @pasyukevich

ishpaul777

minor comments

src/languages/es.ts

ishpaul777 · 2024-11-09T11:42:59Z

src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx

        }
    };

+    const handleNextScreen = useCallback(() => {
+        if (currency !== CONST.CURRENCY.AUD) {
+            goToTheLastStep();


NAB, for now its okay to skip to last step since there are only 3 steps, but in case the number of steps (bodyContent) change this logic may fail.

src/types/form/ReimbursementAccountForm.ts

ishpaul777 · 2024-11-09T11:56:38Z

src/pages/ReimbursementAccount/NonUSD/WhyLink.tsx

+                <TextLink
+                    style={[styles.textMicro]}
+                    // TODO add link
+                    href=""


Link missing, we probably add link from component props since this is used in multiple steps. (assuming different links)

I'm waiting for the exact link here

ishpaul777 · 2024-11-09T12:03:34Z

BUG: Upload bankstatement menu item not redirecting to upload page in confirmation page

Screen.Recording.2024-11-09.at.5.31.18.PM.mov

src/pages/ReimbursementAccount/NonUSD/BankInfo/substeps/Confirmation.tsx

ishpaul777 · 2024-11-09T12:42:38Z

Android Native Sometime app crashes on BankAccount details when focusing on any of field or randomy

Screen.Recording.2024-11-09.at.6.04.42.PM.mov

Screen.Recording.2024-11-09.at.6.13.29.PM.mov

Console error on upload file page

ishpaul777 · 2024-11-12T17:23:09Z

ping me when this is ready for rereview

pasyukevich · 2024-11-12T18:56:07Z

BUG: Upload bankstatement menu item not redirecting to upload page in confirmation page

Fixed - now should redirect as expected

pasyukevich · 2024-11-12T18:57:54Z

@ishpaul777 Could you check that the crash is still reproducible for you on Android - I wasn't able to reproduce it after rebasing

ishpaul777 · 2024-11-12T20:05:56Z

Ok now it work smoothly, before this was hanging too much and also crashing randomly.

One thing i have noticed is when navigating back and changing country from screen 1, it does not rest the bank account input fields and even after changing currency the input field are prefilled, it could be expected just confirming ? @pasyukevich

Screen.Recording.2024-11-13.at.1.30.07.AM.mov

ishpaul777 · 2024-11-12T20:59:21Z

Another bug it seems, when Euro is defalut currecy, the Continue bug does not redirect to next page

Screen.Recording.2024-11-13.at.2.25.11.AM.mov

pasyukevich · 2024-11-13T09:58:43Z

@ishpaul777 For now it is expected - it will be covered later once all steps implemented

ishpaul777 · 2024-11-13T10:05:10Z

Both #52054 (comment) and #52054 (comment)?

pasyukevich · 2024-11-13T10:53:23Z

Another bug it seems, when Euro is defalut currecy, the Continue bug does not redirect to next page

Screen.Recording.2024-11-13.at.2.25.11.AM.mov

Fixed

For some reason, this comment was not visible to me

pasyukevich · 2024-11-13T11:55:34Z

@ishpaul777 Now is ready for rereview

Ok now it work smoothly, before this was hanging too much and also crashing randomly.

One thing i have noticed is when navigating back and changing country from screen 1, it does not rest the bank account input fields and even after changing currency the input field are prefilled, it could be expected just confirming ? @pasyukevich

Screen.Recording.2024-11-13.at.1.30.07.AM.mov

This flow will be covered later once all steps implemented

ishpaul777 · 2024-11-13T16:20:37Z

Will review in ~2hours

ishpaul777

LGTM!

just mention in QA steps that form validation of bank details are not proper because we used dummy fields and validations, actual data will be fetched from BE once its ready, so that QA dont create DB issue for this

madmax330 · 2024-11-14T10:41:20Z

src/libs/actions/BankAccounts.ts

+        isBusinessBankAccount: true,
+    };
+
+    // return API.read(READ_COMMANDS.GET_CORPAY_BANK_ACCOUNT_FIELDS, parameters);


I think the API is ready, but we'll add it in in a the next phase right?

Yes, we will do it in the next step

OSBotify · 2024-11-14T10:53:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-15T14:52:15Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.63-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

kavimuru · 2024-11-15T16:57:27Z

@ishpaul777 @madmax330 is this PR internal PR?
We had a similar one in the past deploy,
#51667 (comment)

ishpaul777 · 2024-11-16T09:04:25Z

i believe so, though i dont have a larger context on how we are handling the QA for this new feature @madmax330 can answer this quesion better

chiragsalian · 2024-11-19T00:25:26Z

Im checking this off the QA checklist since its holding up deploy and i think regular users won't be affected by this flow since they cannot see it atm. @madmax330, can you verify the PR on staging when you get the chance.

github-actions · 2024-11-19T00:55:31Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.63-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

madmax330 · 2024-11-19T16:05:28Z

@pasyukevich can you validate this?
@chiragsalian correct, normal users can't hit this flow.

pasyukevich · 2024-11-20T11:25:16Z

@madmax330 I will be able to validate it once the #52384 is on stage - We will be able to test it in the debug mode

feat: Add Corpay bank info step and update file upload logic

0782b6e

pasyukevich force-pushed the feature/gr-setup-step-2 branch from 543f72d to 0782b6e Compare November 5, 2024 16:00

pasyukevich added 2 commits November 6, 2024 13:22

feat: update translations, bank number last digits

cd911d1

feat: add upload field to the confirmation screen

a2030c4

pasyukevich force-pushed the feature/gr-setup-step-2 branch from 22e7921 to a2030c4 Compare November 6, 2024 12:53

pasyukevich added 5 commits November 6, 2024 14:24

Merge branch 'main' into feature/gr-setup-step-2

723442e

feat: update bank info translations and remove redundant confirmation…

feb5584

… text

fix: text shrinking

3f07571

fix: remove redundant fields from mock data

df49535

fix: update translations

f2cb5a8

pasyukevich marked this pull request as ready for review November 7, 2024 13:26

pasyukevich requested a review from a team as a code owner November 7, 2024 13:26

melvin-bot bot requested review from ishpaul777 and removed request for a team November 7, 2024 13:26

ishpaul777 reviewed Nov 9, 2024

View reviewed changes

src/pages/ReimbursementAccount/NonUSD/BankInfo/substeps/Confirmation.tsx Outdated Show resolved Hide resolved

pasyukevich added 2 commits November 12, 2024 14:42

fix: address comments, redirect to bankstatement page

e8a6264

Merge branch 'main' into feature/gr-setup-step-2

6d2e652

fix: lint

e182f00

fix: redirect on confirm

2ccbe73

ishpaul777 approved these changes Nov 13, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 November 13, 2024 22:44

madmax330 approved these changes Nov 14, 2024

View reviewed changes

madmax330 merged commit 75dd17a into Expensify:main Nov 14, 2024
18 checks passed

github-actions bot mentioned this pull request Nov 15, 2024

Deploy Checklist: New Expensify 2024-11-15 #52618

Closed

37 tasks

melvin-bot bot mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-11-26] [GR Phase 2] Step 2 Bank account details screen (without API calls) #50898

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Corpay bank info step and update file upload logic #52054

feat: Add Corpay bank info step and update file upload logic #52054

pasyukevich commented Nov 5, 2024 •

edited

Loading

melvin-bot bot commented Nov 7, 2024

ishpaul777 commented Nov 8, 2024 •

edited

Loading

ishpaul777 commented Nov 8, 2024

ishpaul777 left a comment

ishpaul777 Nov 9, 2024

ishpaul777 Nov 9, 2024

pasyukevich Nov 12, 2024

ishpaul777 commented Nov 9, 2024

ishpaul777 commented Nov 9, 2024 •

edited

Loading

ishpaul777 commented Nov 12, 2024

pasyukevich commented Nov 12, 2024

pasyukevich commented Nov 12, 2024

ishpaul777 commented Nov 12, 2024

ishpaul777 commented Nov 12, 2024

pasyukevich commented Nov 13, 2024

ishpaul777 commented Nov 13, 2024

pasyukevich commented Nov 13, 2024

pasyukevich commented Nov 13, 2024

ishpaul777 commented Nov 13, 2024

ishpaul777 left a comment

madmax330 Nov 14, 2024

pasyukevich Nov 14, 2024

OSBotify commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

kavimuru commented Nov 15, 2024

ishpaul777 commented Nov 16, 2024

chiragsalian commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

madmax330 commented Nov 19, 2024

pasyukevich commented Nov 20, 2024

feat: Add Corpay bank info step and update file upload logic #52054

feat: Add Corpay bank info step and update file upload logic #52054

Conversation

pasyukevich commented Nov 5, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 7, 2024

ishpaul777 commented Nov 8, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Nov 8, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

ishpaul777 Nov 9, 2024

Choose a reason for hiding this comment

ishpaul777 Nov 9, 2024

Choose a reason for hiding this comment

pasyukevich Nov 12, 2024

Choose a reason for hiding this comment

ishpaul777 commented Nov 9, 2024

ishpaul777 commented Nov 9, 2024 • edited Loading

ishpaul777 commented Nov 12, 2024

pasyukevich commented Nov 12, 2024

pasyukevich commented Nov 12, 2024

ishpaul777 commented Nov 12, 2024

ishpaul777 commented Nov 12, 2024

pasyukevich commented Nov 13, 2024

ishpaul777 commented Nov 13, 2024

pasyukevich commented Nov 13, 2024

pasyukevich commented Nov 13, 2024

ishpaul777 commented Nov 13, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

madmax330 Nov 14, 2024

Choose a reason for hiding this comment

pasyukevich Nov 14, 2024

Choose a reason for hiding this comment

OSBotify commented Nov 14, 2024

github-actions bot commented Nov 15, 2024

kavimuru commented Nov 15, 2024

ishpaul777 commented Nov 16, 2024

chiragsalian commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

madmax330 commented Nov 19, 2024

pasyukevich commented Nov 20, 2024

pasyukevich commented Nov 5, 2024 •

edited

Loading

ishpaul777 commented Nov 8, 2024 •

edited

Loading

ishpaul777 commented Nov 9, 2024 •

edited

Loading