-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disappearing background on Search page #52481
Fix disappearing background on Search page #52481
Conversation
ad6f8ec
to
a4e9afd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Hopefully it resolves the problem and does not introduce any new ones 🤞
@@ -168,7 +168,7 @@ | |||
"react-native-screens": "3.34.0", | |||
"react-native-share": "11.0.2", | |||
"react-native-sound": "^0.11.2", | |||
"react-native-svg": "15.6.0", | |||
"react-native-svg": "15.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to bump react-native-svg, because styling components was broken on android in previous versions.
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@mananjadhav bump |
Reviewing this. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-bg-icon.movAndroid: mWeb Chromemweb-chrome-bg-icon.moviOS: Nativeios-bg-icon.moviOS: mWeb Safarimweb-safari-bg-icon.movMacOS: Chrome / Safariweb-bg-icon.movMacOS: Desktopdesktop-bg-icon.mov |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #51735 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky bug! Thank you for working on this!
@mananjadhav can you complete the reviewer checklist? Looks like you missed a box. Was that intentional? |
@SzymczakJ looks like we also have a broken test? I re-ran it and it failed both times. Seems unrelated but maybe it isn't. |
I missed it by mistake. Completed it. |
@blimpich fixed tests and linter errors |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.66-0 🚀
|
Can you share the platform details? |
Reproducible in iOS |
cc @SzymczakJ |
Yep, it became reproducible again 😢. I'll look into it tomorrow, after I'm done with my current issues. |
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.66-8 🚀
|
Explanation of Change
Fixed Issues
$ #51735
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2024-11-13.at.17.18.06.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop