[Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings #52615

narefyev91 · 2024-11-15T11:51:27Z

Explanation of Change

It was missed correct condition to show loader for online/offline mode for Company cards page

Fixed Issues

$ #52559
PROPOSAL:

Tests

Login to the app
Be sure that you have company cards feature enabled
Choose workspace with enabled company cards
Open Company Cards page
Verify that initial loader is shown

Verify that no errors appear in the JS console

Offline tests

Login to the app
Be sure that you have company cards feature enabled
Choose workspace with enabled company cards
Turn on offline mode
Open Company Cards page
Verify that no loader is shown

QA Steps

Login to the app
Be sure that you have company cards feature enabled
Choose workspace with enabled company cards
Open Company Cards page
Verify that initial loader is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

web.mov

… feed settings

melvin-bot · 2024-11-15T11:51:33Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-11-15T12:31:01Z

@narefyev91 lets mark this Internal QA instead

allgandalf · 2024-11-17T15:19:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-19.at.1.20.01.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-19.at.1.16.22.AM.mov

iOS: Native

Screen.Recording.2024-11-19.at.1.21.35.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-19.at.1.23.41.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-19.at.1.12.05.AM.mov

MacOS: Desktop

Screen.Recording.2024-11-19.at.1.15.19.AM.mov

allgandalf

LGTM and test well! thanks for the quick work @narefyev91 🙇

mountiny

LGTM, thanks!

OSBotify · 2024-11-19T15:38:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-21T01:44:53Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

joekaufmanexpensify · 2024-11-21T15:03:54Z

Tested and QA passed!

One note, we had removed the loader intentionally from the empty state, because we aren't loading any significant data there (and don't have it for the Expensify Card). I assume this added it back for the empty state too?

If it's possible to have it when there are feeds and not for the empty state that would be solid. Otherwise, fine to leave as is.

github-actions · 2024-11-22T19:48:56Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

allgandalf · 2024-12-02T08:47:18Z

src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

@@ -46,10 +46,13 @@ function WorkspaceCompanyCardPage({route}: WorkspaceCompanyCardPageProps) {
        CompanyCards.openPolicyCompanyCardsPage(policyID, workspaceAccountID);
    }, [policyID, workspaceAccountID]);

+    const {isOffline} = useNetwork({onReconnect: fetchCompanyCards});
+    const isLoading = !isOffline && (!cardFeeds || cardFeeds.isLoading);


We should had checked if there is no cardsList present, This missed case caused the loading spinner to show even when we closed the card details RHP and caused the issue #52909. Need to be careful @allgandalf 😓 🙃

Add a loader to the cards page while waiting for cards collection and…

69a41d3

… feed settings

narefyev91 requested a review from a team as a code owner November 15, 2024 11:51

melvin-bot bot requested a review from allgandalf November 15, 2024 11:51

melvin-bot bot removed the request for review from a team November 15, 2024 11:51

narefyev91 changed the title ~~[NO QA]: Add a loader to the cards page while waiting for cards collection and feed settings~~ [Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings Nov 15, 2024

allgandalf approved these changes Nov 18, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny November 18, 2024 19:55

mountiny assigned narefyev91 Nov 19, 2024

mountiny added the InternalQA This pull request required internal QA label Nov 19, 2024

mountiny approved these changes Nov 19, 2024

View reviewed changes

mountiny merged commit fcca690 into Expensify:main Nov 19, 2024
19 checks passed

github-actions bot mentioned this pull request Nov 21, 2024

Deploy Checklist: New Expensify 2024-11-21 #52862

Closed

65 tasks

joekaufmanexpensify mentioned this pull request Nov 21, 2024

[HOLD for payment 2024-11-20] [$250] Brief loading circle when accessing Company Cards page #51333

Closed

allgandalf mentioned this pull request Nov 22, 2024

[Workspace Feeds]: Update isLoading both for expensify and company cards #52949

Merged

58 tasks

melvin-bot bot mentioned this pull request Nov 22, 2024

[HOLD for payment 2024-11-29] [$250] Add a loader to the cards page while waiting for cards collection and feed settings #52559

Closed

allgandalf reviewed Dec 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings #52615

[Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings #52615

narefyev91 commented Nov 15, 2024 •

edited

Loading

melvin-bot bot commented Nov 15, 2024

allgandalf commented Nov 15, 2024

allgandalf commented Nov 17, 2024 •

edited

Loading

allgandalf left a comment

mountiny left a comment

OSBotify commented Nov 19, 2024

github-actions bot commented Nov 21, 2024

joekaufmanexpensify commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

allgandalf Dec 2, 2024

[Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings #52615

[Internal QA]: Add a loader to the cards page while waiting for cards collection and feed settings #52615

Conversation

narefyev91 commented Nov 15, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 15, 2024

allgandalf commented Nov 15, 2024

allgandalf commented Nov 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 19, 2024

github-actions bot commented Nov 21, 2024

joekaufmanexpensify commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

allgandalf Dec 2, 2024

Choose a reason for hiding this comment

narefyev91 commented Nov 15, 2024 •

edited

Loading

allgandalf commented Nov 17, 2024 •

edited

Loading