-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove 'Add personal bank account' task #53319
base: main
Are you sure you want to change the base?
Conversation
@NJ-2020 Can you fix the lint/prettier errors? |
@jjcoffee Done |
@NJ-2020 The second case for the
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeChat and split expenses with friends: android-app-2024-12-04_15.49.17.mp4MacOS: Chrome / SafariGet paid back by employer: desktop-chrome-2024-12-04_15.22.22.mp4Chat and split expenses with friends: desktop-chrome-2024-12-04_15.25.05.mp4 |
Explanation of Change
Fixed Issues
$ #52977
PROPOSAL: #52977 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
'Get paid back by my employer'
option'Add personal bank account'
is removedPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-03.at.20.41.40.mov
Android: mWeb Chrome
Screen.Recording.2024-12-04.at.08.01.11.mov
iOS: Native
Screen.Recording.2024-12-04.at.08.50.02.mov
iOS: mWeb Safari
Screen.Recording.2024-12-04.at.08.13.27.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-04.at.09.12.07.mov
MacOS: Desktop
Screen.Recording.2024-12-04.at.08.58.20.mov