Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v20 upgrade #170

Merged
merged 17 commits into from
Nov 21, 2023
Merged

Node v20 upgrade #170

merged 17 commits into from
Nov 21, 2023

Conversation

arosiclair
Copy link
Contributor

@arosiclair arosiclair commented Oct 31, 2023

$ https://github.com/Expensify/Expensify/issues/316192

  • Upgrades node to v20.9.0 and npm to 10.1.0
  • Fixes new lint errors

Testing this as my current version of K2

@arosiclair arosiclair self-assigned this Oct 31, 2023
@arosiclair arosiclair changed the title Node v20 upgrade [HOLD] Node v20 upgrade Oct 31, 2023
@arosiclair arosiclair marked this pull request as ready for review October 31, 2023 21:58
@arosiclair
Copy link
Contributor Author

I asked about the license check failing here. This is ready for review in the meantime

@arosiclair arosiclair requested a review from a team November 13, 2023 17:11
@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team November 13, 2023 17:12
@arosiclair
Copy link
Contributor Author

Asked about the Snyk license failure here. This is ready for review in the meantime @srikarparsi

@arosiclair
Copy link
Contributor Author

Marked the license check as successful in Snyk since this is an internal app

Copy link
Contributor

@srikarparsi srikarparsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@arosiclair arosiclair changed the title [HOLD] Node v20 upgrade \Node v20 upgrade Nov 21, 2023
@arosiclair arosiclair changed the title \Node v20 upgrade Node v20 upgrade Nov 21, 2023
@arosiclair arosiclair merged commit 152020a into main Nov 21, 2023
3 checks passed
@arosiclair arosiclair deleted the arosiclair-2023-node-upgrade branch November 21, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants