From 373875b807d327e8ac400a16789faca03b499d24 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Jasikowski?= Date: Thu, 3 Oct 2024 10:19:54 +0200 Subject: [PATCH 1/2] Added linting for Firefox in GH actions --- .github/workflows/lint.yml | 12 +++++++++--- assets/manifest-firefox.json | 6 +++--- assets/manifest.json | 7 ------- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 38e12b8b..fb2b07f2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -8,11 +8,13 @@ jobs: lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - name: Checkout repository + uses: actions/checkout@v2 with: fetch-depth: 0 - - uses: actions/cache@v2 + - name: Add build cache + uses: actions/cache@v2 with: path: ~/.npm key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} @@ -31,4 +33,8 @@ jobs: max_attempts: 5 command: npm ci - - run: npx eslint --max-warnings=0 $(git diff --diff-filter=ACM --name-only origin/main '**/*.js' | xargs) + - name: Lint with ESLint + run: npx eslint --max-warnings=0 $(git diff --diff-filter=ACM --name-only origin/main '**/*.js' | xargs) + - name: Lint for Firefox + run: npm run lint:firefox + diff --git a/assets/manifest-firefox.json b/assets/manifest-firefox.json index f38dd3e5..dee44e51 100644 --- a/assets/manifest-firefox.json +++ b/assets/manifest-firefox.json @@ -6,9 +6,9 @@ "description": "Manage your Kernel Scheduling from directly inside GitHub", "browser_specific_settings": { - "gecko": { - "id": "ksv2@expensify.com", - "strict_min_version": "48.0" + "gecko": { + "id": "ksv2@expensify.com", + "strict_min_version": "112.0" } }, diff --git a/assets/manifest.json b/assets/manifest.json index efff8638..ffb23857 100644 --- a/assets/manifest.json +++ b/assets/manifest.json @@ -5,13 +5,6 @@ "version": "1.3.66", "description": "Manage your Kernel Scheduling from directly inside GitHub", - "browser_specific_settings": { - "gecko": { - "id": "ksv2@expensify.com", - "strict_min_version": "42.0" - } - }, - "icons": { "16": "icon16.png", "48": "icon48.png", From 88fd9f6b77e5ba2c51aa10ba438e8f9597cd107d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Jasikowski?= Date: Thu, 3 Oct 2024 10:32:04 +0200 Subject: [PATCH 2/2] Bumped versions --- CHANGELOG.md | 3 +++ assets/manifest-firefox.json | 2 +- assets/manifest.json | 2 +- package-lock.json | 2 +- package.json | 2 +- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a46a0f6b..8774f33e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +#1.3.67 +- Added additional linting and CI for Firefox + #1.3.66 - Added Firefox build script for Manifest V3 compatibility diff --git a/assets/manifest-firefox.json b/assets/manifest-firefox.json index dee44e51..ef2bac96 100644 --- a/assets/manifest-firefox.json +++ b/assets/manifest-firefox.json @@ -2,7 +2,7 @@ "manifest_version": 3, "name": "K2 for GitHub", - "version": "1.3.66", + "version": "1.3.67", "description": "Manage your Kernel Scheduling from directly inside GitHub", "browser_specific_settings": { diff --git a/assets/manifest.json b/assets/manifest.json index ffb23857..697187f8 100644 --- a/assets/manifest.json +++ b/assets/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 3, "name": "K2 for GitHub", - "version": "1.3.66", + "version": "1.3.67", "description": "Manage your Kernel Scheduling from directly inside GitHub", "icons": { diff --git a/package-lock.json b/package-lock.json index 9b125779..5bfc742f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "k2-extension", - "version": "1.3.66", + "version": "1.3.67", "lockfileVersion": 3, "requires": true, "packages": { diff --git a/package.json b/package.json index 48f8585f..d60e3860 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "k2-extension", - "version": "1.3.66", + "version": "1.3.67", "description": "A Chrome Extension for Kernel Schedule", "private": true, "scripts": {