Add @NonNull annotations (#569)

Expensify · Dec 9, 2024 · 83cdfea · 83cdfea
1 parent bb20e3a
commit 83cdfea
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/android/src/main/java/com/expensify/livemarkdown/MarkdownFormatter.java b/android/src/main/java/com/expensify/livemarkdown/MarkdownFormatter.java
@@ -20,7 +20,7 @@ public MarkdownFormatter(@NonNull AssetManager assetManager) {
     mAssetManager = assetManager;
   }
 
-  public void format(SpannableStringBuilder ssb, List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
+  public void format(@NonNull SpannableStringBuilder ssb, @NonNull List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
     try {
       Systrace.beginSection(0, "format");
       Objects.requireNonNull(markdownStyle, "mMarkdownStyle is null");
@@ -31,7 +31,7 @@ public void format(SpannableStringBuilder ssb, List<MarkdownRange> markdownRange
     }
   }
 
-  private void removeSpans(SpannableStringBuilder ssb) {
+  private void removeSpans(@NonNull SpannableStringBuilder ssb) {
     try {
       Systrace.beginSection(0, "removeSpans");
       // We shouldn't use `removeSpans()` because it also removes SpellcheckSpan, SuggestionSpan etc.
@@ -44,7 +44,7 @@ private void removeSpans(SpannableStringBuilder ssb) {
     }
   }
 
-  private void applyRanges(SpannableStringBuilder ssb, List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
+  private void applyRanges(@NonNull SpannableStringBuilder ssb, @NonNull List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
     try {
       Systrace.beginSection(0, "applyRanges");
       for (MarkdownRange markdownRange : markdownRanges) {
@@ -55,7 +55,7 @@ private void applyRanges(SpannableStringBuilder ssb, List<MarkdownRange> markdow
     }
   }
 
-  private void applyRange(SpannableStringBuilder ssb, MarkdownRange markdownRange, MarkdownStyle markdownStyle) {
+  private void applyRange(@NonNull SpannableStringBuilder ssb, @NonNull MarkdownRange markdownRange, @NonNull MarkdownStyle markdownStyle) {
     String type = markdownRange.getType();
     int start = markdownRange.getStart();
     int end = start + markdownRange.getLength();
@@ -126,7 +126,7 @@ private void applyRange(SpannableStringBuilder ssb, MarkdownRange markdownRange,
     }
   }
 
-  private void setSpan(SpannableStringBuilder ssb, MarkdownSpan span, int start, int end) {
+  private void setSpan(@NonNull SpannableStringBuilder ssb, @NonNull MarkdownSpan span, int start, int end) {
     ssb.setSpan(span, start, end, Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
   }
 }
diff --git a/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java b/android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java
@@ -29,9 +29,9 @@ public MarkdownParser(@NonNull ReactContext reactContext) {
     mReactContext = reactContext;
   }
 
-  private native String nativeParse(String text, int parserId);
+  private native String nativeParse(@NonNull String text, int parserId);
 
-  public synchronized List<MarkdownRange> parse(String text, int parserId) {
+  public synchronized List<MarkdownRange> parse(@NonNull String text, int parserId) {
     try {
       Systrace.beginSection(0, "parse");
 

diff --git a/android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java b/android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java
@@ -1,12 +1,14 @@
 package com.expensify.livemarkdown;
 
+import androidx.annotation.NonNull;
+
 public class MarkdownRange {
-  private final String mType;
+  private final @NonNull String mType;
   private final int mStart;
   private final int mLength;
   private final int mDepth;
 
-  public MarkdownRange(String type, int start, int length, int depth) {
+  public MarkdownRange(@NonNull String type, int start, int length, int depth) {
     mType = type;
     mStart = start;
     mLength = length;

diff --git a/android/src/main/java/com/expensify/livemarkdown/MarkdownStyle.java b/android/src/main/java/com/expensify/livemarkdown/MarkdownStyle.java
@@ -32,6 +32,7 @@ public class MarkdownStyle {
 
   private final float mBlockquotePaddingLeft;
 
+  @NonNull
   private final String mCodeFontFamily;
 
   private final float mCodeFontSize;
@@ -42,6 +43,7 @@ public class MarkdownStyle {
   @ColorInt
   private final int mCodeBackgroundColor;
 
+  @NonNull
   private final String mPreFontFamily;
 
   private final float mPreFontSize;

diff --git a/android/src/main/java/com/expensify/livemarkdown/MarkdownTextWatcher.java b/android/src/main/java/com/expensify/livemarkdown/MarkdownTextWatcher.java
@@ -7,7 +7,7 @@
 import androidx.annotation.NonNull;
 
 public class MarkdownTextWatcher implements TextWatcher {
-  private final MarkdownUtils mMarkdownUtils;
+  private final @NonNull MarkdownUtils mMarkdownUtils;
 
   public MarkdownTextWatcher(@NonNull MarkdownUtils markdownUtils) {
     mMarkdownUtils = markdownUtils;