Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React Native 0.76] Update the Android commit hook to rely on libreactnative.so #457

Closed
j-piasecki opened this issue Aug 21, 2024 · 0 comments · Fixed by #483
Closed

[React Native 0.76] Update the Android commit hook to rely on libreactnative.so #457

j-piasecki opened this issue Aug 21, 2024 · 0 comments · Fixed by #483

Comments

@j-piasecki
Copy link
Collaborator

Description

Starting with React Native 0.76 the number of shared libraries shipped by the framework will be greatly reduced. This will affect the new-architecture part of the library as it links against quite a few of them.

This will need to be updated with the accordance to the above proposal:

# Example for a library called `mylibrary` which used to
# link against `react_render_core`, `react_render_uimanager` and `jsi`
# but from 0.76 will just link against `reactnative` and `jsi`

- target_link_libraries(mylibrary 
- 	ReactAndroid::react_render_core 
-   ReactAndroid::react_render_uimanager 
-   ReactAndroid::jsi
- )

+# This if-then-else can be removed once this library does not support version below 0.76
+if (REACTNATIVE_MERGED_SO)
+   target_link_libraries(mylibrary ReactAndroid::reactnative)
+else()
+   target_link_libraries(mylibrary 
+      ReactAndroid::react_render_core 
+      ReactAndroid::react_render_uimanager
+   )
+endif()
+target_link_libraries(mylibrary ReactAndroid::jsi)

It would be best to start work on upgrading it relatively soon to release of the first release candidate of 0.76 which would allow us to catch any problems quickly and possibly fix the issues (if any are found) upstream.

@j-piasecki j-piasecki linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant