-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix selection prop #313
Merged
Skalakid
merged 7 commits into
main
from
@Skalakid/fix-setting-cursor-position-by-selection-prop
Apr 24, 2024
Merged
Fix selection prop #313
Skalakid
merged 7 commits into
main
from
@Skalakid/fix-setting-cursor-position-by-selection-prop
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skalakid
force-pushed
the
@Skalakid/fix-setting-cursor-position-by-selection-prop
branch
from
April 15, 2024 15:20
17183c3
to
a6dc9d0
Compare
6 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine, let me test it 👀
BartoszGrajdek
approved these changes
Apr 24, 2024
Skalakid
deleted the
@Skalakid/fix-setting-cursor-position-by-selection-prop
branch
April 24, 2024 10:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes cursor position in following scenarios:
Related Issues
Expensify/App#39360
Slack comment: https://swmansion.slack.com/archives/C06BDSWLDPB/p1712253259974309?thread_ts=1712171205.597509&cid=C06BDSWLDPB
Manual Tests
Linked PRs